From: "Radim Krčmář" <rkrcmar@redhat.com>
To: Peter Xu <peterx@redhat.com>
Cc: qemu-devel@nongnu.org, Igor Mammedov <imammedo@redhat.com>,
Paolo Bonzini <pbonzini@redhat.com>,
Richard Henderson <rth@twiddle.net>,
Eduardo Habkost <ehabkost@redhat.com>,
"Michael S. Tsirkin" <mst@redhat.com>
Subject: Re: [Qemu-devel] [PATCH 3/5] intel_iommu: pass whole remapped addresses to apic
Date: Tue, 27 Sep 2016 15:56:06 +0200 [thread overview]
Message-ID: <20160927135606.GC26148@potion> (raw)
In-Reply-To: <20160923094122.GC29144@pxdev.xzpeter.org>
2016-09-23 17:41+0800, Peter Xu:
> On Thu, Sep 22, 2016 at 11:04:30PM +0200, Radim Krčmář wrote:
>
> [...]
>
>> @@ -279,18 +280,16 @@ static void vtd_update_iotlb(IntelIOMMUState *s, uint16_t source_id,
>> static void vtd_generate_interrupt(IntelIOMMUState *s, hwaddr mesg_addr_reg,
>> hwaddr mesg_data_reg)
>> {
>> - hwaddr addr;
>> - uint32_t data;
>> + MSIMessage msi;
>>
>> assert(mesg_data_reg < DMAR_REG_SIZE);
>> assert(mesg_addr_reg < DMAR_REG_SIZE);
>>
>> - addr = vtd_get_long_raw(s, mesg_addr_reg);
>> - data = vtd_get_long_raw(s, mesg_data_reg);
>> + msi.address = vtd_get_long_raw(s, mesg_addr_reg);
>> + msi.data = vtd_get_long_raw(s, mesg_data_reg);
>>
>> VTD_DPRINTF(FLOG, "msi: addr 0x%"PRIx64 " data 0x%"PRIx32, addr, data);
>
> Need to fix addr/data as well?
Oops, thanks.
next prev parent reply other threads:[~2016-09-27 13:56 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-22 21:04 [Qemu-devel] [PATCH 0/5] intel_iommu: fix EIM Radim Krčmář
2016-09-22 21:04 ` [Qemu-devel] [PATCH 1/5] apic: add global apic_get_class() Radim Krčmář
2016-09-23 9:17 ` Peter Xu
2016-09-27 13:28 ` Radim Krčmář
2016-09-22 21:04 ` [Qemu-devel] [PATCH 2/5] apic: add send_msi() to APICCommonClass Radim Krčmář
2016-09-23 9:35 ` Peter Xu
2016-09-26 12:38 ` Igor Mammedov
2016-09-27 13:55 ` Radim Krčmář
2016-09-22 21:04 ` [Qemu-devel] [PATCH 3/5] intel_iommu: pass whole remapped addresses to apic Radim Krčmář
2016-09-23 9:41 ` Peter Xu
2016-09-27 13:56 ` Radim Krčmář [this message]
2016-09-27 13:57 ` Igor Mammedov
2016-09-22 21:04 ` [Qemu-devel] [PATCH 4/5] intel_iommu: add "eim" property Radim Krčmář
2016-09-22 21:04 ` [Qemu-devel] [PATCH 5/5] intel_iommu: do not allow EIM without KVM support Radim Krčmář
2016-09-23 9:27 ` Paolo Bonzini
2016-09-23 10:02 ` Peter Xu
2016-09-23 10:03 ` Paolo Bonzini
2016-09-23 10:12 ` Peter Xu
2016-09-23 10:39 ` Paolo Bonzini
2016-09-23 10:52 ` Peter Xu
2016-09-27 14:01 ` Radim Krčmář
2016-09-27 21:30 ` Paolo Bonzini
2016-09-27 13:07 ` Igor Mammedov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160927135606.GC26148@potion \
--to=rkrcmar@redhat.com \
--cc=ehabkost@redhat.com \
--cc=imammedo@redhat.com \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peterx@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=rth@twiddle.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).