qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Fam Zheng <famz@redhat.com>
To: "Gonglei (Arei)" <arei.gonglei@huawei.com>
Cc: "Daniel P. Berrange" <berrange@redhat.com>,
	"pbonzini@redhat.com" <pbonzini@redhat.com>,
	John Snow <jsnow@redhat.com>,
	"qemu-devel@nongnu.org" <qemu-devel@nongnu.org>,
	"Wubin (H)" <wu.wubin@huawei.com>
Subject: Re: [Qemu-devel] [PATCH RFC] tests: Run qtest cases in parallel
Date: Wed, 28 Sep 2016 09:45:28 +0800	[thread overview]
Message-ID: <20160928014528.GB1284@lemon> (raw)
In-Reply-To: <33183CC9F5247A488A2544077AF19020B03DB4E4@SZXEMA503-MBS.china.huawei.com>

On Wed, 09/28 01:31, Gonglei (Arei) wrote:
> # ./tests/virtio-net-test
> **
> ERROR:tests/libqtest.c:561:qtest_get_arch: assertion failed: (qemu != NULL)
> Aborted (core dumped)
> 
> # ./tests/virtio-blk-test
> **
> ERROR:tests/libqtest.c:561:qtest_get_arch: assertion failed: (qemu != NULL)
> Aborted (core dumped)
> 
> But they work after I set the environment variable to specify architecture:
>  
> # QTEST_QEMU_BINARY=x86_64-softmmu/qemu-system-x86_64 ./tests/virtio-net-test
> /x86_64/virtio/net/pci/basic: OK
> /x86_64/virtio/net/pci/rx_stop_cont: OK
> /x86_64/virtio/net/pci/hotplug: OK
> 
> # QTEST_QEMU_BINARY=x86_64-softmmu/qemu-system-x86_64 ./tests/virtio-blk-test
> /x86_64/virtio/blk/pci/basic: OK
> /x86_64/virtio/blk/pci/indirect: OK
> /x86_64/virtio/blk/pci/config: OK
> /x86_64/virtio/blk/pci/msix: OK
> /x86_64/virtio/blk/pci/idx: OK
> /x86_64/virtio/blk/pci/hotplug: OK
> 
> So, Maybe we should add check if the environment relied on is set
> before executing specific operations in this kind of tests. Right?

Or make a guess based on $(realpath $0]) (in this case, print the found path to
avoid testing against wrong binary by mistake).

Fam

  reply	other threads:[~2016-09-28  1:45 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-08-12  9:19 [Qemu-devel] [PATCH RFC] tests: Run qtest cases in parallel Fam Zheng
2016-09-21 18:24 ` John Snow
2016-09-23  7:58   ` Fam Zheng
2016-09-23  9:39     ` Gonglei (Arei)
2016-09-23  9:59       ` Fam Zheng
2016-09-24  2:37         ` Gonglei (Arei)
2016-09-27 10:14         ` Daniel P. Berrange
2016-09-28  1:31           ` Gonglei (Arei)
2016-09-28  1:45             ` Fam Zheng [this message]
2016-09-28  1:54               ` Gonglei (Arei)
2016-09-28  2:10                 ` Fam Zheng
2016-09-27 10:17     ` Daniel P. Berrange
2016-09-27 10:58       ` Fam Zheng

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160928014528.GB1284@lemon \
    --to=famz@redhat.com \
    --cc=arei.gonglei@huawei.com \
    --cc=berrange@redhat.com \
    --cc=jsnow@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=wu.wubin@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).