From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:59702)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <groug@kaod.org>) id 1bp8CD-0005Le-WB
	for qemu-devel@nongnu.org; Wed, 28 Sep 2016 02:18:22 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <groug@kaod.org>) id 1bp8C9-0004fJ-VG
	for qemu-devel@nongnu.org; Wed, 28 Sep 2016 02:18:21 -0400
Received: from 12.mo5.mail-out.ovh.net ([46.105.39.65]:45318)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <groug@kaod.org>) id 1bp8C9-0004f9-PJ
	for qemu-devel@nongnu.org; Wed, 28 Sep 2016 02:18:17 -0400
Received: from player799.ha.ovh.net (b9.ovh.net [213.186.33.59])
	by mo5.mail-out.ovh.net (Postfix) with ESMTP id 1DC6A1B614
	for <qemu-devel@nongnu.org>; Wed, 28 Sep 2016 08:18:16 +0200 (CEST)
Date: Wed, 28 Sep 2016 08:18:11 +0200
From: Greg Kurz <groug@kaod.org>
Message-ID: <20160928081811.18e68d2c@bahia>
In-Reply-To: <CAKXe6SLjt5+ViTa_gHEtufv=-Cen-4j9eBm8jagojbRsnvCfJQ@mail.gmail.com>
References: <57ea5b9f.87941c0a.d0b87.d5b6@mx.google.com>
	<20160927184010.0ef68530@bahia.lab.toulouse-stg.fr.ibm.com>
	<CAKXe6SLjt5+ViTa_gHEtufv=-Cen-4j9eBm8jagojbRsnvCfJQ@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH] 9pfs: make unmarshal V9fsString more robust
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel/>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: =?UTF-8?B?5p2O5by6?= <liq3ea@gmail.com>
Cc: aneesh.kumar@linux.vnet.ibm.com, qemu-devel@nongnu.org, Li Qiang <liqiang6-s@360.cn>

On Wed, 28 Sep 2016 10:14:00 +0800
=E6=9D=8E=E5=BC=BA <liq3ea@gmail.com> wrote:

> On 2016-09-28 0:40 GMT+08:00 Greg Kurz <groug@kaod.org> wrote:
>=20
> >
> > Talking about robustness was appropriate for your previous patches, but
> > it does not really apply here since v9fs_iov_vunmarshal() does not have
> > any issue with empty strings actually.
> >
> > I've changed the title to:
> >
> > 9pfs: allocate space for guest originated empty strings
> >
> > And while here, I've updated the changelog to provide a more detailed
> > justification:
> >
> > ...
>=20
> Thanks very much to point out the mistakes, I will do more next time.
>=20
> BTW, need I resend this patch formally?
>=20

No, that's ok.

> Thanks.