From: Kevin Wolf <kwolf@redhat.com>
To: Wang WeiWei <wangww.fnst@cn.fujitsu.com>
Cc: qemu devel <qemu-devel@nongnu.org>,
qemu block <qemu-block@nongnu.org>,
Stefan Hajnoczi <stefanha@redhat.com>,
Fam Zheng <famz@redhat.com>, Max Reitz <mreitz@redhat.com>,
Jeff Cody <jcody@redhat.com>, Paolo Bonzini <pbonzini@redhat.com>,
John Snow <jsnow@redhat.com>, Eric Blake <eblake@redhat.com>,
Markus Armbruster <armbru@redhat.com>,
"Dr. David Alan Gilbert" <dgilbert@redhat.com>,
Dong Eddie <eddie.dong@intel.com>,
Jiang Yunhong <yunhong.jiang@intel.com>,
zhanghailiang <zhang.zhanghailiang@huawei.com>,
Gonglei <arei.gonglei@huawei.com>,
Wen Congyang <wency@cn.fujitsu.com>,
Changlong Xie <xiecl.fnst@cn.fujitsu.com>
Subject: Re: [Qemu-devel] [PATCH] block: modify top-id's comments
Date: Wed, 28 Sep 2016 11:03:25 +0200 [thread overview]
Message-ID: <20160928090325.GF5236@noname.redhat.com> (raw)
In-Reply-To: <1475040639-30203-1-git-send-email-wangww.fnst@cn.fujitsu.com>
Am 28.09.2016 um 07:30 hat Wang WeiWei geschrieben:
> Signed-off-by: Wen Congyang <wency@cn.fujitsu.com>
> Signed-off-by: Changlong Xie <xiecl.fnst@cn.fujitsu.com>
> Signed-off-by: Wang WeiWei <wangww.fnst@cn.fujitsu.com>
> Signed-off-by: zhanghailiang <zhang.zhanghailiang@huawei.com>
> Signed-off-by: Gonglei <arei.gonglei@huawei.com>
> Reviewed-by: Eric Blake <eblake@redhat.com>
> ---
> qapi/block-core.json | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/qapi/block-core.json b/qapi/block-core.json
> index ada3202..0935b81 100644
> --- a/qapi/block-core.json
> +++ b/qapi/block-core.json
> @@ -2184,7 +2184,7 @@
> # @mode: the replication mode
> #
> # @top-id: #optional In secondary mode, node name or device ID of the root
> -# node who owns the replication node chain. Ignored in primary mode.
> +# node who owns the replication node chain. Must not be given in primary mode.
> #
> # Since: 2.8
> ##
The matching code in block/replication.c is missing to actually error
out if the option is given in primary mode.
Kevin
next prev parent reply other threads:[~2016-09-28 9:03 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-28 5:30 [Qemu-devel] [PATCH] block: modify top-id's comments Wang WeiWei
2016-09-28 9:03 ` Kevin Wolf [this message]
2016-09-28 10:31 ` [Qemu-devel] [Qemu-block] " Stefan Hajnoczi
2016-09-29 13:35 ` Eric Blake
2016-09-30 8:30 ` wangweiwei
-- strict thread matches above, loose matches on Subject: below --
2016-09-30 8:53 [Qemu-devel] " Wang WeiWei
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160928090325.GF5236@noname.redhat.com \
--to=kwolf@redhat.com \
--cc=arei.gonglei@huawei.com \
--cc=armbru@redhat.com \
--cc=dgilbert@redhat.com \
--cc=eblake@redhat.com \
--cc=eddie.dong@intel.com \
--cc=famz@redhat.com \
--cc=jcody@redhat.com \
--cc=jsnow@redhat.com \
--cc=mreitz@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
--cc=wangww.fnst@cn.fujitsu.com \
--cc=wency@cn.fujitsu.com \
--cc=xiecl.fnst@cn.fujitsu.com \
--cc=yunhong.jiang@intel.com \
--cc=zhang.zhanghailiang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).