From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:52851) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bpB3C-0006Ga-NP for qemu-devel@nongnu.org; Wed, 28 Sep 2016 05:21:18 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bpB38-00065f-74 for qemu-devel@nongnu.org; Wed, 28 Sep 2016 05:21:13 -0400 Received: from mx1.redhat.com ([209.132.183.28]:35868) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bpB38-00065V-0Y for qemu-devel@nongnu.org; Wed, 28 Sep 2016 05:21:10 -0400 Date: Wed, 28 Sep 2016 10:21:05 +0100 From: "Daniel P. Berrange" Message-ID: <20160928092105.GH21583@redhat.com> Reply-To: "Daniel P. Berrange" References: <1474994958-6007-1-git-send-email-felipe@nutanix.com> <20160927172323.GS3967@redhat.com> <256D7E5B-CA2E-4338-B407-FB1333D9007F@nutanix.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <256D7E5B-CA2E-4338-B407-FB1333D9007F@nutanix.com> Subject: Re: [Qemu-devel] [PATCH] io: Fix double shift usages on QIOChannel features List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Felipe Franciosi Cc: Marc-Andre Lureau , Paolo Bonzini , "qemu-devel@nongnu.org" On Tue, Sep 27, 2016 at 06:35:41PM +0000, Felipe Franciosi wrote: > > > On 27 Sep 2016, at 18:23, Daniel P. Berrange wrote: > > > > On Tue, Sep 27, 2016 at 09:49:18AM -0700, Felipe Franciosi wrote: > >> > >> Signed-off-by: Felipe Franciosi > >> --- > >> io/channel-socket.c | 11 ++++++----- > >> io/channel-tls.c | 4 ++-- > >> io/channel-websock.c | 4 ++-- > >> io/channel.c | 10 ++++------ > >> migration/qemu-file-channel.c | 3 +-- > >> qemu-char.c | 3 +-- > >> 6 files changed, 16 insertions(+), 19 deletions(-) > > > > The test/test-io-channel-*.c unit tests should be updated to > > validate the correct handling. > > Hi Daniel, > > Actually it looks like all tests are using the has_feature() wrapper > already, so I'm not sure I need to fix anything here. Please let me > know if I missed something. If we had full test coverage of the feature flags, then we should have seen a test failure for this bug. So there must be something we're not exercising in the test suite. Regards, Daniel -- |: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :| |: http://libvirt.org -o- http://virt-manager.org :| |: http://entangle-photo.org -o- http://search.cpan.org/~danberr/ :|