From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:32901) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bpBVN-0007ZD-8u for qemu-devel@nongnu.org; Wed, 28 Sep 2016 05:50:22 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bpBVL-00084p-C3 for qemu-devel@nongnu.org; Wed, 28 Sep 2016 05:50:20 -0400 Date: Wed, 28 Sep 2016 11:50:10 +0200 From: Kevin Wolf Message-ID: <20160928095010.GJ5236@noname.redhat.com> References: <1474985217-21690-1-git-send-email-stefanha@redhat.com> <1474985217-21690-2-git-send-email-stefanha@redhat.com> <059434c4-67c0-9d8f-8089-e58d7fe952fc@redhat.com> <84ac6f55-83af-610a-df84-219a018f3d9e@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <84ac6f55-83af-610a-df84-219a018f3d9e@redhat.com> Subject: Re: [Qemu-devel] [PATCH 1/3] coroutine: add qemu_coroutine_entered() function List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: Stefan Hajnoczi , Stefan Hajnoczi , qemu-devel , Fam Zheng , qemu block , Roman Pen Am 27.09.2016 um 18:55 hat Paolo Bonzini geschrieben: > > > On 27/09/2016 18:29, Stefan Hajnoczi wrote: > > On Tue, Sep 27, 2016 at 5:20 PM, Paolo Bonzini wrote: > >> > >> > >> On 27/09/2016 16:06, Stefan Hajnoczi wrote: > >>> See the doc comments for a description of this new coroutine API. > >>> > >>> Signed-off-by: Stefan Hajnoczi > >>> --- > >>> include/qemu/coroutine.h | 13 +++++++++++++ > >>> util/qemu-coroutine.c | 5 +++++ > >>> 2 files changed, 18 insertions(+) > >>> > >>> diff --git a/include/qemu/coroutine.h b/include/qemu/coroutine.h > >>> index 29a2078..e6a60d5 100644 > >>> --- a/include/qemu/coroutine.h > >>> +++ b/include/qemu/coroutine.h > >>> @@ -92,6 +92,19 @@ Coroutine *coroutine_fn qemu_coroutine_self(void); > >>> */ > >>> bool qemu_in_coroutine(void); > >>> > >>> +/** > >>> + * Return true if the coroutine is currently entered > >>> + * > >>> + * A coroutine is "entered" if it has not yielded from the current > >>> + * qemu_coroutine_enter() call used to run it. This does not mean that the > >>> + * coroutine is currently executing code since it may have transferred control > >>> + * to another coroutine using qemu_coroutine_enter(). > >>> + * > >>> + * When several coroutines enter each other there may be no way to know which > >>> + * ones have already been entered. In such situations this function can be > >>> + * used to avoid recursively entering coroutines. > >>> + */ > >>> +bool qemu_coroutine_entered(Coroutine *co); > >> > >> Perhaps qemu_coroutine_running is a better name? > > > > I find "running" confusing since the coroutine may not actually be > > currently executing (as mentioned in the doc comment). > > Ok, makes sense. Another possibility is qemu_coroutine_on_stack, but > I'm not sure it's better... Maybe qemu_coroutine_active()? Kevin