From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:43122)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1bpC9W-0007Qd-Pb
	for qemu-devel@nongnu.org; Wed, 28 Sep 2016 06:31:51 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1bpC9T-0003DN-Ib
	for qemu-devel@nongnu.org; Wed, 28 Sep 2016 06:31:50 -0400
Date: Wed, 28 Sep 2016 11:31:44 +0100
From: Stefan Hajnoczi <stefanha@gmail.com>
Message-ID: <20160928103144.GC4196@stefanha-x1.localdomain>
References: <1475040639-30203-1-git-send-email-wangww.fnst@cn.fujitsu.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature"; boundary="0vzXIDBeUiKkjNJl"
Content-Disposition: inline
In-Reply-To: <1475040639-30203-1-git-send-email-wangww.fnst@cn.fujitsu.com>
Subject: Re: [Qemu-devel] [Qemu-block] [PATCH] block: modify top-id's
 comments
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel/>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Wang WeiWei <wangww.fnst@cn.fujitsu.com>
Cc: qemu devel <qemu-devel@nongnu.org>, qemu block <qemu-block@nongnu.org>, Stefan Hajnoczi <stefanha@redhat.com>, Fam Zheng <famz@redhat.com>, Max Reitz <mreitz@redhat.com>, Kevin Wolf <kwolf@redhat.com>, Jeff Cody <jcody@redhat.com>, Changlong Xie <xiecl.fnst@cn.fujitsu.com>, zhanghailiang <zhang.zhanghailiang@huawei.com>, Wen Congyang <wency@cn.fujitsu.com>, Jiang Yunhong <yunhong.jiang@intel.com>, Dong Eddie <eddie.dong@intel.com>, Markus Armbruster <armbru@redhat.com>, "Dr. David Alan Gilbert" <dgilbert@redhat.com>, Gonglei <arei.gonglei@huawei.com>, Paolo Bonzini <pbonzini@redhat.com>


--0vzXIDBeUiKkjNJl
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Wed, Sep 28, 2016 at 01:30:39PM +0800, Wang WeiWei wrote:

Please send a proper commit message and commit description.  "modify
top-id's comments" says almost nothing and there is no commit
description.  I don't know why you are making this change so I can't
review and apply it.

> Signed-off-by: Wen Congyang <wency@cn.fujitsu.com>
> Signed-off-by: Changlong Xie <xiecl.fnst@cn.fujitsu.com>
> Signed-off-by: Wang WeiWei <wangww.fnst@cn.fujitsu.com>
> Signed-off-by: zhanghailiang <zhang.zhanghailiang@huawei.com>
> Signed-off-by: Gonglei <arei.gonglei@huawei.com>
> Reviewed-by: Eric Blake <eblake@redhat.com>
> ---
>  qapi/block-core.json | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>=20
> diff --git a/qapi/block-core.json b/qapi/block-core.json
> index ada3202..0935b81 100644
> --- a/qapi/block-core.json
> +++ b/qapi/block-core.json
> @@ -2184,7 +2184,7 @@
>  # @mode: the replication mode
>  #
>  # @top-id: #optional In secondary mode, node name or device ID of the ro=
ot
> -#          node who owns the replication node chain. Ignored in primary =
mode.
> +#          node who owns the replication node chain. Must not be given i=
n primary mode.
>  #
>  # Since: 2.8
>  ##
> --=20
> 1.9.3
>=20
>=20
>=20
>=20

--0vzXIDBeUiKkjNJl
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEcBAEBAgAGBQJX65wQAAoJEJykq7OBq3PIFXUH/i33K2Q7/oxlFfOvyotX+abU
klGpx/YPE1o74NB5oVEKqy5lvOkw5+HsVJUf+GY42zcF2ta69wOr2H74pQP81fv7
xmdJwoL9bwiK6mCVWw0cM2+fpg2gmM++dGrwG3T8w+Vrox6lycEd09tVHqoBlgAU
pNx+6eyJqy1zVpKXsIfD9wpO5J+gvPY1w8Me9wtPNEhZOvIt+1QrxZXn/o9zUF1/
tiwI3KoaIfPrBsHgSoeplOssskvIOHT/sAZcF+SUj1Bo1zb2D0OUlKjEOUCELtn5
otQp2hwJIKXvHXVsNbo4E937tHyZgusqktDV/hvnTJFwZJjMNJNvjgnA5Z9ez6c=
=Ui2M
-----END PGP SIGNATURE-----

--0vzXIDBeUiKkjNJl--