From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:40640) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bpPwm-0008RJ-7a for qemu-devel@nongnu.org; Wed, 28 Sep 2016 21:15:37 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bpPwj-0004FI-0w for qemu-devel@nongnu.org; Wed, 28 Sep 2016 21:15:36 -0400 Date: Thu, 29 Sep 2016 11:14:05 +1000 From: David Gibson Message-ID: <20160929011405.GL18880@umbus> References: <1475061390-17644-1-git-send-email-thuth@redhat.com> <1475061390-17644-2-git-send-email-thuth@redhat.com> <88b71216-877e-6dc9-42ec-a17a13d17d89@kaod.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="zH41lVBEV8cLJnCl" Content-Disposition: inline In-Reply-To: <88b71216-877e-6dc9-42ec-a17a13d17d89@kaod.org> Subject: Re: [Qemu-devel] [PATCH 1/3] hw/ppc/spapr: Move code related to "ibm, pa-features" to a separate function List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: =?iso-8859-1?Q?C=E9dric?= Le Goater Cc: Thomas Huth , qemu-ppc@nongnu.org, Alexander Graf , qemu-devel@nongnu.org, Anton Blanchard --zH41lVBEV8cLJnCl Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Sep 28, 2016 at 03:07:31PM +0200, C=E9dric Le Goater wrote: > On 09/28/2016 01:16 PM, Thomas Huth wrote: > > The function spapr_populate_cpu_dt() has become quite big > > already, and since we likely have to extend the pa-features > > property for every new processor generation, it is nicer > > if we put the related code into a separate function. >=20 > Looks good to me, >=20 > Reviewed-by: C=E9dric Le Goater >=20 > Thanks, >=20 > C.=20 >=20 > (It would be really nice to have a routine to build pa_features=20 > in a less cryptic way. ) Applied, thanks. --=20 David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson --zH41lVBEV8cLJnCl Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBCAAGBQJX7GrbAAoJEGw4ysog2bOSzREP/AveVeqgzT38cD38B6sXJOnL BcAIjN5wpywJ/aMBPhUSnYbtakqMihv0QAma18t9IhgknrThOC2L3FPDz+DKyFJu Mqi3XPAYUazVME9ebw67UFfc0NxQNtAYqWPi5pk00RyhGzIhH5M1b1Nt8pqga800 Xj1uLbqiGyGOivZ+giA/qP5XcpKb6ABsFSTujGQ4f+GUaOFbPllXjAPPhiuv4T+x bvjCDqHnaLViDtOl/9UI/e0mYAlTYMZ98os32LD9pjtZhlbBJlBNupqDOoqbY9zj SB+uR6U0OgCqpJS/1xcOMGXHKfqMr6zG6qbFboG1RVHxoSzgkfLDokMFEq9o+gDl GbqNoSkC26C5j0054ERgE3SmUXts2DDZlDgtB1fFF9A3nzRdO7HfSs0LZXMsVLVm yPYpgo30gChnRV5rQ+o0NRzAZxsWHtY7HqR93sSO+Td8KnL0rJ6jZKXYxKOXPU16 71Dje+tnkHcCnANxm8msrQ4sqDTG53QkxfRynby6LKXeFUrp33PcCwRV4railkWU qvdTEIZaaRUx96o0iGD6+OvgwUimHtvuSGa/yzteqPZEXrgYhqMKiIck8kDbKWCO q80RBBYrtr833vmhHtPFd9f9rjf7Uv69z/o20dqYAF+nXU+E2oPYfU/imKzjbNQ4 bV6GN/M6qbNqJ6kNQZEs =L9FY -----END PGP SIGNATURE----- --zH41lVBEV8cLJnCl--