From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:49695) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bpR34-0000mI-5A for qemu-devel@nongnu.org; Wed, 28 Sep 2016 22:26:11 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bpR33-0002Ak-6O for qemu-devel@nongnu.org; Wed, 28 Sep 2016 22:26:10 -0400 Date: Thu, 29 Sep 2016 11:53:25 +1000 From: David Gibson Message-ID: <20160929015325.GD8390@umbus.fritz.box> References: <1475088120-20244-1-git-send-email-nikunj@linux.vnet.ibm.com> <1475088120-20244-4-git-send-email-nikunj@linux.vnet.ibm.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="IMjqdzrDRly81ofr" Content-Disposition: inline In-Reply-To: Subject: Re: [Qemu-devel] [PATCH v5 3/9] target-ppc: Implement mtvsrws instruction List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Richard Henderson Cc: Nikunj A Dadhania , qemu-ppc@nongnu.org, qemu-devel@nongnu.org, benh@kernel.crashing.org, Ravi Bangoria --IMjqdzrDRly81ofr Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Sep 28, 2016 at 01:21:00PM -0700, Richard Henderson wrote: > On 09/28/2016 11:41 AM, Nikunj A Dadhania wrote: > > + tcg_gen_mov_i64(t0, cpu_gpr[rA(ctx->opcode)]); > > + tcg_gen_deposit_i64(cpu_vsrl(xT(ctx->opcode)), t0, t0, 32, 32); >=20 > Why are you using t0? Richard, I don't quite understand your question. This looks correct to me. It's duplicating the low 32-bits of rA into both the low-and high 32-bits of t0, which will then be store to both the low and high 64-bit elements of the VSR. That matches the instruction definition which puts the low 32-bits of RA into every 32-bit element of the vector. --=20 David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson --IMjqdzrDRly81ofr Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBCAAGBQJX7HQVAAoJEGw4ysog2bOSqogQAKkfmdYViXxWPjDfM+hYMuUJ e62c9t5WN4u0YaMoANEvIyIGK3GjPU7mvTxqhSYFNHBVH46kJbLe5xvZ1TOXzhY2 fj73WUvzouBo8JDPjdnHBM5Nl5EW9OGvNYrIhTV4Mydl0I5gMXDqo0wgBMkdv2oV CnNEdJqWTpkOgYnmLiVaWlmiHizjPKTH9ytF+gp6cEmykI2iFGwG858UpDyLMtsX BumpYPLIdNSM64EkTEl7Ip/4lTIrrtlSdedvtbZluM72cAnbwg2SoUj97T+8bqey LtMYxoSbODoU1RapoIijSJWHLosNlPBjzyU63iQvUyV3rbnDdaYtchImNPfY5GZ2 DJYAd43h6Cy3FyE8Vb9+rDCZFqBgzUTcHme1doYw4jHs2Sn7vhI6jbzVeGS694EZ 4YUc/SlBC9DCI06WouBmZrZKwG1xg6kWrk0r3Qhf2pot7LbEP9rjS6qxhTVhefMD hGdeqq8rUs6KTm2kqrhWDntkTV01ux6b4oitZmLlXJ9k8C1qnjqTynjsIng3zAPK OqOGklEQxH/g55l6G4xCP0Oqf1aOad/h8JSao9IWEWK55xJMiztBOnlzMMkeCNuA fO7Pt7/k/7Gqcrfxri+b7WOnR9ka7sBxwZqsyhHoIGiKvw7gHmdRNRf2jl2RiMHP vPDqdJ3MBP0HpS591EfU =Yma6 -----END PGP SIGNATURE----- --IMjqdzrDRly81ofr--