From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:49738) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bpR36-0000n2-7A for qemu-devel@nongnu.org; Wed, 28 Sep 2016 22:26:13 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bpR34-0002Br-Mw for qemu-devel@nongnu.org; Wed, 28 Sep 2016 22:26:12 -0400 Date: Thu, 29 Sep 2016 12:22:37 +1000 From: David Gibson Message-ID: <20160929022237.GF8390@umbus.fritz.box> References: <1475041518-9757-1-git-send-email-raji@linux.vnet.ibm.com> <1475041518-9757-5-git-send-email-raji@linux.vnet.ibm.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="6v9BRtpmy+umdQlo" Content-Disposition: inline In-Reply-To: <1475041518-9757-5-git-send-email-raji@linux.vnet.ibm.com> Subject: Re: [Qemu-devel] [PATCH 4/6] target-ppc: fix invalid mask - cmpl, bctar List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Rajalakshmi Srinivasaraghavan Cc: qemu-ppc@nongnu.org, rth@twiddle.net, qemu-devel@nongnu.org, nikunj@linux.vnet.ibm.com, benh@kernel.crashing.org, Avinesh Kumar --6v9BRtpmy+umdQlo Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Sep 28, 2016 at 11:15:16AM +0530, Rajalakshmi Srinivasaraghavan wro= te: > From: Avinesh Kumar >=20 > cmpl: invalid bit mask should be 0x00400001 > bctar: invalid bit mask should be 0x0000E000 >=20 > Signed-off-by: Avinesh Kumar > Signed-off-by: Rajalakshmi Srinivasaraghavan > Applied to ppc-for-2.8. > --- > target-ppc/translate.c | 4 ++-- > 1 files changed, 2 insertions(+), 2 deletions(-) >=20 > diff --git a/target-ppc/translate.c b/target-ppc/translate.c > index 8eefd82..dab8f19 100644 > --- a/target-ppc/translate.c > +++ b/target-ppc/translate.c > @@ -6203,7 +6203,7 @@ static opcode_t opcodes[] =3D { > GEN_HANDLER(invalid, 0x00, 0x00, 0x00, 0xFFFFFFFF, PPC_NONE), > GEN_HANDLER(cmp, 0x1F, 0x00, 0x00, 0x00400000, PPC_INTEGER), > GEN_HANDLER(cmpi, 0x0B, 0xFF, 0xFF, 0x00400000, PPC_INTEGER), > -GEN_HANDLER(cmpl, 0x1F, 0x00, 0x01, 0x00400000, PPC_INTEGER), > +GEN_HANDLER(cmpl, 0x1F, 0x00, 0x01, 0x00400001, PPC_INTEGER), > GEN_HANDLER(cmpli, 0x0A, 0xFF, 0xFF, 0x00400000, PPC_INTEGER), > #if defined(TARGET_PPC64) > GEN_HANDLER_E(cmpeqb, 0x1F, 0x00, 0x07, 0x00600000, PPC_NONE, PPC2_ISA30= 0), > @@ -6297,7 +6297,7 @@ GEN_HANDLER(b, 0x12, 0xFF, 0xFF, 0x00000000, PPC_FL= OW), > GEN_HANDLER(bc, 0x10, 0xFF, 0xFF, 0x00000000, PPC_FLOW), > GEN_HANDLER(bcctr, 0x13, 0x10, 0x10, 0x00000000, PPC_FLOW), > GEN_HANDLER(bclr, 0x13, 0x10, 0x00, 0x00000000, PPC_FLOW), > -GEN_HANDLER_E(bctar, 0x13, 0x10, 0x11, 0, PPC_NONE, PPC2_BCTAR_ISA207), > +GEN_HANDLER_E(bctar, 0x13, 0x10, 0x11, 0x0000E000, PPC_NONE, PPC2_BCTAR_= ISA207), > GEN_HANDLER(mcrf, 0x13, 0x00, 0xFF, 0x00000001, PPC_INTEGER), > GEN_HANDLER(rfi, 0x13, 0x12, 0x01, 0x03FF8001, PPC_FLOW), > #if defined(TARGET_PPC64) --=20 David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson --6v9BRtpmy+umdQlo Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBCAAGBQJX7HrqAAoJEGw4ysog2bOSRb8P/jA1eb3VZl/l9baznxSQXX+/ uQgRiCyjBGkqvZGufmzgZq8niHKK+zhxp9V1q8lzbZppHfOvsN1AWHGDz/IBA8B6 IjL3JHXhw2LbqvSfxfgQJkNDas2NxDB272g62fUj2Boyg0cct6pWFK+IolBIrfuf f1z6DOWua5+26BM1J6LGRJ3YkgRk220GfHmyHB0xnRQtsSbuMqyGM2u0cZxQGE9W CsuRTmjs1ouJ33ekJ/0+tiyqp2WGtKPVQGLkZxrjHNua3645rymfZ5oLGUPSeukT 3reyG5dtOZPDgKhAZBkoasr7rD+V09Ig5thHUNYG5JSOU1kK6uDg9ykPANhq2y3N OFgC7vP7TkS+ijjh7BpX68swo7RcFmkINJcM2gr7/NxuTrNrJd3olIeD/CKvYqoC zyFh+6K4k4aIT1hTYZnn7GzUwfYG2n3ZQCo+nI6IIqIPnkHcP3YC+6o3ObcuJIsx +NlDb0nnYlcu+td17y3hYOiMPZoWWFyAXWi9jaWmNWnXec8MVdti2YJbu3zLIWyK Q1nKfqoL2zhcpVcfxmFLfJUWaU3he8JEm1gEBurS8cK3PQUL+0s+2TdWdDGGC5eY J+c7JfL9KYnnWHRuD49UYfo/w7bLoFUZBnAlkmF//u/TW4y7PkYk4TwgcAWtPZn5 G0eLt61UBIeajUR5/tO7 =7u4b -----END PGP SIGNATURE----- --6v9BRtpmy+umdQlo--