From: Fam Zheng <famz@redhat.com>
To: Max Reitz <mreitz@redhat.com>
Cc: qemu-devel@nongnu.org, qemu-block@nongnu.org,
Kevin Wolf <kwolf@redhat.com>,
qemu-stable@nongnu.org, stefanha@redhat.com, pbonzini@redhat.com
Subject: Re: [Qemu-devel] [PATCH v2 1/5] blockdev-mirror: Sanity check before moving target_bs AioContext
Date: Thu, 29 Sep 2016 11:14:44 +0800 [thread overview]
Message-ID: <20160929031444.GE6412@lemon> (raw)
In-Reply-To: <6d56ac2d-aa76-f323-085b-54f0dd4e519c@redhat.com>
On Wed, 09/28 18:37, Max Reitz wrote:
> On 27.09.2016 08:37, Fam Zheng wrote:
> > Similar to blockdev-backup, if the target was already moved to a
> > different AioContext, bad things can happen. This happens when the
> > target belongs to a data plane device. It's a very unlikely case, but
> > let's check it anyway.
>
> You didn't implement it for blockdev-mirror, though, but for
> drive-mirror (which I don't think needs this check).
Ugh, will fix.
next prev parent reply other threads:[~2016-09-29 3:14 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-27 6:37 [Qemu-devel] [PATCH v2 0/5] block: keep AioContext pointer in BlockBackend Fam Zheng
2016-09-27 6:37 ` [Qemu-devel] [PATCH v2 1/5] blockdev-mirror: Sanity check before moving target_bs AioContext Fam Zheng
2016-09-28 16:37 ` Max Reitz
2016-09-29 3:14 ` Fam Zheng [this message]
2016-09-27 6:37 ` [Qemu-devel] [PATCH v2 2/5] blockdev: Move BDS AioContext before inserting to BB Fam Zheng
2016-09-28 17:09 ` Max Reitz
2016-09-27 6:37 ` [Qemu-devel] [PATCH v2 3/5] block: Introduce and make use of blk_new_with_root Fam Zheng
2016-09-28 17:21 ` Max Reitz
2016-09-27 6:37 ` [Qemu-devel] [PATCH v2 4/5] migration: Set correct AioContext to BlockBackend Fam Zheng
2016-09-28 17:26 ` Max Reitz
2016-09-27 6:37 ` [Qemu-devel] [PATCH v2 5/5] block: keep AioContext pointer in BlockBackend Fam Zheng
2016-09-28 17:47 ` Max Reitz
2016-09-29 3:05 ` Fam Zheng
2016-09-29 7:47 ` Paolo Bonzini
2016-09-30 5:22 ` Fam Zheng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160929031444.GE6412@lemon \
--to=famz@redhat.com \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-stable@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).