From: Kashyap Chamarthy <kchamart@redhat.com>
To: "Daniel P. Berrange" <berrange@redhat.com>
Cc: Fam Zheng <famz@redhat.com>,
kwolf@redhat.com, qemu-block@nongnu.org, qemu-devel@nongnu.org,
Stefan Hajnoczi <stefanha@redhat.com>
Subject: Re: [Qemu-devel] RFC: handling image options with drive-mirror/drive-backup
Date: Thu, 29 Sep 2016 11:47:10 +0200 [thread overview]
Message-ID: <20160929094710.nj6r7daypajrrfbp@eukaryote> (raw)
In-Reply-To: <20160929085109.GG5312@redhat.com>
On Thu, Sep 29, 2016 at 09:51:09AM +0100, Daniel P. Berrange wrote:
> On Thu, Sep 29, 2016 at 04:43:25PM +0800, Fam Zheng wrote:
> > On Thu, 09/29 09:34, Daniel P. Berrange wrote:
[...]
> > > So my suggestion is that we deprecate "drive-mirror" and define a fixed
> > > command "drive-mirror-blockdev" (or "blockdev-mirror" ?) that accepts
> > > the proper BlockdevOptions QAPI type for the target as above.
> >
> > Are you aware that there is already a blockdev-mirror command? Supposedly it
> > can do what you need, together with blockdev-add once the latter is deemed
> > ready.
>
> Clearly I'm not aware of that :-) It seems libvirt does not yet use
> blockdev-mirror either, which is where I got the original bug report
> about drive-mirror from.
>
> I'll submit a patch to mark drive-mirror as deprecated and point the
> otherwise ignorant reader towards blockdev-mirror instead....
You might also want to see this short thread I started last month to
clarify the semantics of `drive-mirror` & `blockdev-mirror`
https://lists.nongnu.org/archive/html/qemu-block/2016-08/msg00472.html
-- 'drive-mirror' vs. 'blockdev-mirror' semantics
Kevin's response to the above:
https://lists.nongnu.org/archive/html/qemu-block/2016-08/msg00493.html
Some addendum to Kevin's response above:
https://lists.nongnu.org/archive/html/qemu-block/2016-08/msg00503.html
And FWIW, here's some tests of `blockdev-add` + `blockdev-backup`
(`blockdev-mirror` is similar, just a different point-in-time --
point-in-time for 'drive-mirror' is when you break the synchronization;
and the point-in-time for 'drive-backup' is when you _start_ the
operation):
https://kashyapc.fedorapeople.org/virt/qemu/blockdev-add-and-blockdev-backup-success-tests.txt
--
/kashyap
prev parent reply other threads:[~2016-09-29 9:47 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-29 8:34 [Qemu-devel] RFC: handling image options with drive-mirror/drive-backup Daniel P. Berrange
2016-09-29 8:43 ` Fam Zheng
2016-09-29 8:51 ` Daniel P. Berrange
2016-09-29 9:09 ` Fam Zheng
2016-09-29 9:15 ` Daniel P. Berrange
2016-09-29 9:25 ` Fam Zheng
2016-09-29 9:17 ` Kevin Wolf
2016-09-29 9:43 ` Daniel P. Berrange
2016-09-29 10:29 ` Kashyap Chamarthy
2016-09-29 10:37 ` Kevin Wolf
2016-09-29 9:47 ` Kashyap Chamarthy [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160929094710.nj6r7daypajrrfbp@eukaryote \
--to=kchamart@redhat.com \
--cc=berrange@redhat.com \
--cc=famz@redhat.com \
--cc=kwolf@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).