qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Radim Krčmář" <rkrcmar@redhat.com>
To: Igor Mammedov <imammedo@redhat.com>
Cc: Paolo Bonzini <pbonzini@redhat.com>,
	qemu-devel@nongnu.org, Peter Xu <peterx@redhat.com>,
	Richard Henderson <rth@twiddle.net>,
	Eduardo Habkost <ehabkost@redhat.com>,
	"Michael S. Tsirkin" <mst@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v2 6/7] intel_iommu: reject broken EIM
Date: Thu, 29 Sep 2016 18:56:26 +0200	[thread overview]
Message-ID: <20160929165626.GC12788@potion> (raw)
In-Reply-To: <20160929180654.782b73c1@nial.brq.redhat.com>

2016-09-29 18:06+0200, Igor Mammedov:
> On Thu, 29 Sep 2016 15:18:36 +0200
> Paolo Bonzini <pbonzini@redhat.com> wrote:
>> On 29/09/2016 13:23, Radim Krčmář wrote:
>> > Cluster x2APIC cannot work without KVM's x2apic API when the maximal
>> > APIC ID is greater than 8 and only KVM's LAPIC can support x2APIC, so we
>> > forbid other APICs and also the old KVM case with less than 9, to
>> > simplify the code.
>> > 
>> > There is no point in enabling EIM in forbidden APICs, so we keep it
>> > enabled only for the KVM APIC;  unconditionally, because making the
>> > option depend on KVM version would be a maintanance burden.
>> > 
>> > Signed-off-by: Radim Krčmář <rkrcmar@redhat.com>
>> > ---
>> > v2:
>> >  * adapt to new intr_eim parameter
>> >  * provide first linux version that has x2apic api
>> >  * disable QEMU's LAPIC
>> > ---
>> > diff --git a/hw/i386/intel_iommu.c b/hw/i386/intel_iommu.c
>> > @@ -2481,7 +2482,20 @@ static void vtd_realize(DeviceState *dev, Error **errp)
>> >          s->intr_eim = ON_OFF_AUTO_OFF;
>> >      }
>> >      if (s->intr_eim == ON_OFF_AUTO_AUTO) {
>> > -        s->intr_eim = ON_OFF_AUTO_ON;
>> > +        s->intr_eim = kvm_irqchip_in_kernel() ? ON_OFF_AUTO_ON
>> > +                                              : ON_OFF_AUTO_OFF;
>> > +    }
>> > +    if (s->intr_eim == ON_OFF_AUTO_ON) {
>> > +        if (kvm_irqchip_in_kernel() && !kvm_enable_x2apic()) {
>> > +            error_report("intel-iommu,eim=on requires support on the KVM side "
>> > +                         "(X2APIC_API, first shipped in v4.7).");
>> > +            exit(1);  
>> 
>> Please use error_setg and return instead (same in patches 4 and 5).
> Radim's version is consistent with error handling used throughout the file.
> If we are to use preferred error_setg() here that preceding cleanup
> patch is in order to convert error_reports to error_setg.

There is one more error_report() in the file and it doesn't have
"Error **" -- I'll leave it be and change the rest.
It amounts to one extra patch that before [4/7] (could be squashed too).

>> > +        }
>> > +        if (!kvm_irqchip_in_kernel()) {
>> > +            error_report("intel-iommu,eim=on requires "
>> > +                         "accel=kvm,kernel-irqchip=split.");
> this prints:
>  -device intel-iommu,intremap=on,eim=on: intel-iommu,eim=on requires accel=kvm,kernel-irqchip=split
> so 'intel-iommu,' not really needed, the same would happen with error_setg()

Yeah, really unreadable, thanks.

  reply	other threads:[~2016-09-29 16:56 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-09-29 11:23 [Qemu-devel] [PATCH v2 0/7] intel_iommu: fix EIM Radim Krčmář
2016-09-29 11:23 ` [Qemu-devel] [PATCH v2 1/7] apic: add global apic_get_class() Radim Krčmář
2016-09-29 14:53   ` Eduardo Habkost
2016-09-29 15:58     ` Radim Krčmář
2016-09-29 11:23 ` [Qemu-devel] [PATCH v2 2/7] apic: add send_msi() to APICCommonClass Radim Krčmář
2016-09-29 11:23 ` [Qemu-devel] [PATCH v2 3/7] intel_iommu: pass whole remapped addresses to apic Radim Krčmář
2016-09-29 11:23 ` [Qemu-devel] [PATCH v2 4/7] intel-iommu: exit on invalid configuraton earlier Radim Krčmář
2016-09-29 11:23 ` [Qemu-devel] [PATCH v2 5/7] intel-iommu: add OnOffAuto intr_eim as "eim" property Radim Krčmář
2016-09-30  5:13   ` Peter Xu
2016-09-30 13:50     ` Radim Krčmář
2016-09-29 11:23 ` [Qemu-devel] [PATCH v2 6/7] intel_iommu: reject broken EIM Radim Krčmář
2016-09-29 13:18   ` Paolo Bonzini
2016-09-29 16:06     ` Igor Mammedov
2016-09-29 16:56       ` Radim Krčmář [this message]
2016-09-29 16:56         ` Paolo Bonzini
2016-09-29 15:53   ` Igor Mammedov
2016-09-29 11:23 ` [Qemu-devel] [PATCH v2 7/7] intel-iommu: keep buggy EIM enabled in 2.7 machine type Radim Krčmář
2016-09-29 13:19   ` Paolo Bonzini
2016-09-29 15:01   ` Eduardo Habkost
2016-09-29 16:49     ` Radim Krčmář
2016-09-30  5:40   ` Peter Xu
2016-09-30 13:55     ` Radim Krčmář

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160929165626.GC12788@potion \
    --to=rkrcmar@redhat.com \
    --cc=ehabkost@redhat.com \
    --cc=imammedo@redhat.com \
    --cc=mst@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=peterx@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=rth@twiddle.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).