Re: [Qemu-devel] [PATCH 0/2] net: pcnet: fix infinite loop and source format

[no-reply@patchew.org]

Hi,

Your series seems to have some coding style problems. See output below for
more information:

Type: series
Message-id: 1475175454-3116-1-git-send-email-ppandit@redhat.com
Subject: [Qemu-devel] [PATCH 0/2] net: pcnet: fix infinite loop and source format

=== TEST SCRIPT BEGIN ===
#!/bin/bash

BASE=base
n=1
total=$(git log --oneline $BASE.. | wc -l)
failed=0

# Useful git options
git config --local diff.renamelimit 0
git config --local diff.renames True

commits="$(git log --format=%H --reverse $BASE..)"
for c in $commits; do
    echo "Checking PATCH $n/$total: $(git show --no-patch --format=%s $c)..."
    if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then
        failed=1
        echo
    fi
    n=$((n+1))
done

exit $failed
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
Switched to a new branch 'test'
aa6ffbb net: pcnet: fix source formatting and indentation
71981b1 net: pcnet: check rx/tx descriptor ring length

=== OUTPUT BEGIN ===
Checking PATCH 1/2: net: pcnet: check rx/tx descriptor ring length...
Checking PATCH 2/2: net: pcnet: fix source formatting and indentation...
ERROR: spaces required around that '<=' (ctx:VxV)
#164: FILE: hw/net/pcnet.c:1290:
+        if (CSR_XMTRC(s)<=1) {
                         ^

ERROR: suspect code indent for conditional statements (8, 10)
#187: FILE: hw/net/pcnet.c:1309:
+        } else if (count--) {
           goto txagain;

ERROR: suspect code indent for conditional statements (8, 10)
#235: FILE: hw/net/pcnet.c:1378:
+        if ((val&7) == 7) {
           val &= ~3;

ERROR: spaces required around that '&' (ctx:VxV)
#235: FILE: hw/net/pcnet.c:1378:
+        if ((val&7) == 7) {
                 ^

ERROR: suspect code indent for conditional statements (7, 11)
#267: FILE: hw/net/pcnet.c:1442:
+       if (CSR_STOP(s) || CSR_SPND(s)) {
            break;

total: 5 errors, 0 warnings, 250 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

=== OUTPUT END ===

Test command exited with code: 1


---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to patchew-devel@freelists.org