Re: [Qemu-devel] [PATCH] CODING_STYLE: Fix a typo ("Many a flamewar")

["Jonathan Neuschäfer" <j.neuschaefer@gmx.net>]

[-- Attachment #1: Type: text/plain, Size: 1201 bytes --]

On Thu, Sep 29, 2016 at 03:14:45PM -0700, Peter Maydell wrote:
> On 29 September 2016 at 13:46, Jonathan Neuschäfer
> <j.neuschaefer@gmx.net> wrote:
> > Signed-off-by: Jonathan Neuschäfer <j.neuschaefer@gmx.net>
> > ---
> >  CODING_STYLE | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/CODING_STYLE b/CODING_STYLE
> > index e7fde15..a03a994 100644
> > --- a/CODING_STYLE
> > +++ b/CODING_STYLE
> > @@ -9,7 +9,7 @@ patches before submitting.
> >  Of course, the most important aspect in any coding style is whitespace.
> >  Crusty old coders who have trouble spotting the glasses on their noses
> >  can tell the difference between a tab and eight spaces from a distance
> > -of approximately fifteen parsecs.  Many a flamewar have been fought and
> > +of approximately fifteen parsecs.  Many flamewars have been fought and
> >  lost on this issue.
> 
> Should be "Many a flamewar has been fought and lost".
> (This is slightly poetic phrasing but it has a nice ring to it;
> the complement does have to be singular, not plural, though.)

Thanks for pointing that out; I didn't know the phrase. I'll update my
patch.


Jonathan Neuschäfer

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]