From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:43796) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bpolD-0001CB-Rz for qemu-devel@nongnu.org; Thu, 29 Sep 2016 23:45:21 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bpolC-00075O-FE for qemu-devel@nongnu.org; Thu, 29 Sep 2016 23:45:19 -0400 Date: Fri, 30 Sep 2016 13:36:35 +1000 From: David Gibson Message-ID: <20160930033635.GA22534@umbus.fritz.box> References: <1467046804-9832-1-git-send-email-duanj@linux.vnet.ibm.com> <9f8c7823-11ec-9df5-2c4f-2cb68231fe29@linux.vnet.ibm.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="5vNYLRcllDrimb99" Content-Disposition: inline In-Reply-To: <9f8c7823-11ec-9df5-2c4f-2cb68231fe29@linux.vnet.ibm.com> Subject: Re: [Qemu-devel] [Qemu-ppc] [QEMU PATCH v4 0/6] migration: ensure hotplug and migration work together List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Jianjun Duan Cc: qemu-devel@nongnu.org, veroniabahaa@gmail.com, peter.maydell@linaro.org, mst@redhat.com, quintela@redhat.com, mdroth@linux.vnet.ibm.com, mreitz@redhat.com, blauwirbel@gmail.com, amit.shah@redhat.com, qemu-ppc@nongnu.org, kraxel@redhat.com, kwolf@redhat.com, dmitry@daynix.com, pbonzini@redhat.com, rth@twiddle.net, leon.alrae@imgtec.com, dgilbert@redhat.com --5vNYLRcllDrimb99 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Sep 29, 2016 at 09:55:30AM -0700, Jianjun Duan wrote: > ping I'm sorry, this fell off my radar. Can you please rebase and resend your latest version. >=20 > On 06/27/2016 09:59 AM, Jianjun Duan wrote: > > Hi all, > > The previous patches seem to get buried deep somewhere. I am resendi= ng them > > without RFC tag. Comments are welcome. > >=20 > > v4: - Introduce a way to set customized instance_id in SaveStateEntry. = Use it > > to set instance_id for DRC using its unique index to address Davi= d=20 > > Gibson's concern. > > - Rename VMS_CSTM to VMS_LINKED based on Paolo Bonzini's suggestion= s. > > - Clean up qjson stuff in put_qtailq.=20 > > - Add trace for put_qtailq and get_qtailq based on David Gilbert's= =20 > > suggestion. > >=20 > > It is based on David's ppc-for-2.7. Comments are welcome. Previous vers= ions are: > >=20 > > v3: - Simplify overall design followng discussion with Paolo. No longer= need > > metadata to migrate QTAILQ. > > - Extend VMStateInfo instead of adding similar fields to VMStateFie= ld. > > - Clean up macros in qemu/queue.h. > > (link: https://lists.nongnu.org/archive/html/qemu-devel/2016-05/msg0569= 5.html) > >=20 > > v2: - Introduce a general approach to migrate QTAILQ in qemu/queue.h. > > - Migrate signalled field in the DRC state. > > - Put the newly added migrating fields in subsections so that backw= ard=20 > > migration is not broken. =20 > > - Set detach_cb field right after migration so that a migrated hot-= unplug > > event could finish its course. > > (link: https://lists.nongnu.org/archive/html/qemu-devel/2016-05/msg0418= 8.html) > >=20 > > v1: - Inital version. > > (link: https://lists.nongnu.org/archive/html/qemu-devel/2016-04/msg0260= 1.html) > >=20 > > To make guest device (PCI, CPU and memory) hotplug work together=20 > > with guest migration, spapr drc state needs be transmitted in > > migration. This patch defines the VMStateDescription struct for > > spapr drc state to enable it. > >=20 > > To fix the potential racing between hotplug events on guest and=20 > > guest migration, ccs_list and pending_events of spapr state need be=20 > > transmitted in migration. This patch also takes care of it. > >=20 > > Jianjun Duan (6): > > migration: alternative way to set instance_id in SaveStateEntry > > migration: spapr_drc: defined VMStateDescription struct > > migration: extend VMStateInfo > > migration: migrate QTAILQ > > migration: spapr: migrate ccs_list in spapr state > > migration: spapr: migrate pending_events of spapr state > >=20 > > hw/net/vmxnet3.c | 18 +++-- > > hw/nvram/eeprom93xx.c | 6 +- > > hw/nvram/fw_cfg.c | 6 +- > > hw/pci/msix.c | 6 +- > > hw/pci/pci.c | 12 ++-- > > hw/pci/shpc.c | 5 +- > > hw/ppc/spapr.c | 67 ++++++++++++++++++ > > hw/ppc/spapr_drc.c | 69 +++++++++++++++++++ > > hw/ppc/spapr_events.c | 22 +++--- > > hw/ppc/spapr_pci.c | 22 ++++++ > > hw/scsi/scsi-bus.c | 6 +- > > hw/timer/twl92230.c | 6 +- > > hw/usb/redirect.c | 18 +++-- > > hw/virtio/virtio-pci.c | 6 +- > > hw/virtio/virtio.c | 6 +- > > include/hw/ppc/spapr.h | 3 +- > > include/hw/ppc/spapr_drc.h | 9 +++ > > include/hw/qdev-core.h | 6 ++ > > include/migration/vmstate.h | 36 ++++++++-- > > include/qemu/queue.h | 32 +++++++++ > > migration/savevm.c | 25 +++++-- > > migration/vmstate.c | 161 ++++++++++++++++++++++++++++++++++--= -------- > > target-alpha/machine.c | 5 +- > > target-arm/machine.c | 12 ++-- > > target-i386/machine.c | 21 ++++-- > > target-mips/machine.c | 10 +-- > > target-ppc/machine.c | 10 +-- > > target-sparc/machine.c | 5 +- > > trace-events | 4 ++ > > 29 files changed, 505 insertions(+), 109 deletions(-) > >=20 >=20 --=20 David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson --5vNYLRcllDrimb99 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBCAAGBQJX7d2+AAoJEGw4ysog2bOSmNsP/0BxOnmXEaJHnNH4NukZO0ve JmguC1IgVLecRjJPHux3fsAlY/Lpj3jJDe6gPNTxYOrDnW8mXBGkcUFL8YpCAULf 8QsJUbCut/EeHpEMOBnRPC9XpTEiO+VFSs2FxAhIlRiYzFpQo/NHQoluJfTK5LEt pBlB8l7gettGAJ69vQfbdSjhy1PzcRYwLF72J83yg6DaaEpgI0cevOMAwVP68P3z jZ6OE1bLWXq/MjMeBbp45jPMJTOunCYPP5P3xmSIcCOzolH9EwO/cMsOCJ9zf9wL Eof+90jn9cQwJzi2yCyHL16FnONHi5u1PpYRUb988qindC9H6QbD1sRzDRsJmKue 52L0UGzP1TwSwMU/tai2tYvw2N4kw8tl78Maij5DGiMyu2uKM1ntjt4wUt7yrnkU fuqD0XTM5HoPjm0PSeCgTElqE5cOISVTPvRX8YIX++wMMw9/NLyWlyFnPO2v1/Yy LuPPuIuxnXXvGUFsyclsiLWfpl36N5nM7Onj+i4m2X1Lr2BJBTnLQPPw1MFnqAdL 8ptGIH4PhXI8qzgD658WTyphHJOCu7tY6U2if6iZxbqXbZYKN8f99Euz6KvOrQHv rR/N5hxx1L69ztFNp6jTlSAG+lU45v+wipSVlbVPAj12RfvI8dcDjEzAdHI0hD/c eD0nxe2cC7OhlDGT9MHT =VM0T -----END PGP SIGNATURE----- --5vNYLRcllDrimb99--