From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:49624) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bq5Ou-0006Rb-DF for qemu-devel@nongnu.org; Fri, 30 Sep 2016 17:31:25 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bq5Or-0006Vf-NQ for qemu-devel@nongnu.org; Fri, 30 Sep 2016 17:31:23 -0400 Received: from mail-wm0-x22e.google.com ([2a00:1450:400c:c09::22e]:37273) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bq5Or-0006VL-Hf for qemu-devel@nongnu.org; Fri, 30 Sep 2016 17:31:21 -0400 Received: by mail-wm0-x22e.google.com with SMTP id b80so66255069wme.0 for ; Fri, 30 Sep 2016 14:31:21 -0700 (PDT) From: =?UTF-8?q?Alex=20Benn=C3=A9e?= Date: Fri, 30 Sep 2016 22:30:54 +0100 Message-Id: <20160930213106.20186-4-alex.bennee@linaro.org> In-Reply-To: <20160930213106.20186-1-alex.bennee@linaro.org> References: <20160930213106.20186-1-alex.bennee@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Subject: [Qemu-devel] [PATCH v3 03/15] exec-all.h: revert tb_page_addr_t to target_ulong List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org, pbonzini@redhat.com Cc: mttcg@listserver.greensocs.com, fred.konrad@greensocs.com, a.rigo@virtualopensystems.com, cota@braap.org, bobby.prani@gmail.com, nikunj@linux.vnet.ibm.com, mark.burton@greensocs.com, jan.kiszka@siemens.com, serge.fdrv@gmail.com, rth@twiddle.net, peter.maydell@linaro.org, claudio.fontana@huawei.com, =?UTF-8?q?Alex=20Benn=C3=A9e?= , Peter Crosthwaite Commit b480d9b74 converted tb_page_addr_t to abi_ulong which while the right size imposes additional alignment restrictions on the type. This gets in the way of using atomic accesses on certain guest platforms which allow finer alignments. As tb_page_addr_t isn't actually visible to the guest we can revert the change. This is potentially less efficient for ILP32 style guests but it is the simpler change to make. Signed-off-by: Alex Bennée --- include/exec/exec-all.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/exec/exec-all.h b/include/exec/exec-all.h index 336a57c..c3596a6 100644 --- a/include/exec/exec-all.h +++ b/include/exec/exec-all.h @@ -30,7 +30,7 @@ addresses in userspace mode. Define tb_page_addr_t to be an appropriate type. */ #if defined(CONFIG_USER_ONLY) -typedef abi_ulong tb_page_addr_t; +typedef target_ulong tb_page_addr_t; #else typedef ram_addr_t tb_page_addr_t; #endif -- 2.9.3