From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:42539) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bqcCa-0004ND-S7 for qemu-devel@nongnu.org; Sun, 02 Oct 2016 04:32:53 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bqcCV-0001Nw-ST for qemu-devel@nongnu.org; Sun, 02 Oct 2016 04:32:52 -0400 Received: from 6.mo177.mail-out.ovh.net ([46.105.51.249]:35038) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bqcCV-0001Nh-MS for qemu-devel@nongnu.org; Sun, 02 Oct 2016 04:32:47 -0400 Received: from player779.ha.ovh.net (b9.ovh.net [213.186.33.59]) by mo177.mail-out.ovh.net (Postfix) with ESMTP id DE35AFF9B27 for ; Sun, 2 Oct 2016 10:32:46 +0200 (CEST) Date: Sun, 2 Oct 2016 10:32:41 +0200 From: Greg Kurz Message-ID: <20161002103241.1a7ca8a1@bahia> In-Reply-To: <1475348164-8593-3-git-send-email-lvivier@redhat.com> References: <1475348164-8593-1-git-send-email-lvivier@redhat.com> <1475348164-8593-3-git-send-email-lvivier@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v3 2/5] tests: don't check if qtest_spapr_boot() returns NULL List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Laurent Vivier Cc: qemu-devel@nongnu.org, dgibson@redhat.com, thuth@redhat.com, qemu-ppc@nongnu.org On Sat, 1 Oct 2016 20:56:01 +0200 Laurent Vivier wrote: > qtest_spapr_boot()/qtest_pc_boot()/qtest_boot() call qtest_vboot() > and qtest_vboot() calls g_malloc(), > and g_malloc() never fails: > if memory allocation fails, the application is terminated. > > Signed-off-by: Laurent Vivier > --- Reviewed-by: Greg Kurz > tests/libqos/libqos.c | 1 + > tests/rtas-test.c | 1 - > 2 files changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tests/libqos/libqos.c b/tests/libqos/libqos.c > index 7abb482..65d6296 100644 > --- a/tests/libqos/libqos.c > +++ b/tests/libqos/libqos.c > @@ -10,6 +10,7 @@ > /** > * Launch QEMU with the given command line, > * and then set up interrupts and our guest malloc interface. > + * Never return NULL as the application is terminated if g_malloc() fails. > */ > QOSState *qtest_vboot(QOSOps *ops, const char *cmdline_fmt, va_list ap) > { > diff --git a/tests/rtas-test.c b/tests/rtas-test.c > index ba0867a..276c87e 100644 > --- a/tests/rtas-test.c > +++ b/tests/rtas-test.c > @@ -14,7 +14,6 @@ static void test_rtas_get_time_of_day(void) > time_t t1, t2; > > qs = qtest_spapr_boot("-machine pseries"); > - g_assert(qs != NULL); > > t1 = time(NULL); > ret = qrtas_get_time_of_day(qs->alloc, &tm, &ns);