From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:58065) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1br3Fg-000895-6E for qemu-devel@nongnu.org; Mon, 03 Oct 2016 09:25:58 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1br3Fc-0003Wt-V3 for qemu-devel@nongnu.org; Mon, 03 Oct 2016 09:25:52 -0400 Received: from mx1.redhat.com ([209.132.183.28]:60534) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1br3Fc-0003Wc-Nv for qemu-devel@nongnu.org; Mon, 03 Oct 2016 09:25:48 -0400 Date: Mon, 3 Oct 2016 14:25:46 +0100 From: Stefan Hajnoczi Message-ID: <20161003132546.GB10245@stefanha-x1.localdomain> References: <1475068103-356-1-git-send-email-berrange@redhat.com> <1475068103-356-3-git-send-email-berrange@redhat.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="xgyAXRrhYN0wYx8y" Content-Disposition: inline In-Reply-To: <1475068103-356-3-git-send-email-berrange@redhat.com> Subject: Re: [Qemu-devel] [PATCH v5 02/20] trace: remove double-underscore in event name List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Daniel P. Berrange" Cc: qemu-devel@nongnu.org, =?iso-8859-1?Q?Llu=EDs?= Vilanova --xgyAXRrhYN0wYx8y Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Sep 28, 2016 at 02:08:05PM +0100, Daniel P. Berrange wrote: > If there is a double underscore in an event name, at least > systemtap 3.0 will turn that into a single underscore. This > in turn breaks the generated QEMU code that calls this > event. The generated-tracers.h file calls a macro called > QEMU_SPAPR_VSCSI__PROCESS_LOGIN, but the corresponding > generated-tracers-dtrace.h file defines a macro called > QEMU_SPAPR_VSCSI_PROCESS_LOGIN. >=20 > It is unclear if this removal of double underscores is > intended behaviour of systemtap or not. So rather than > try to change the tracetool to generate the systemtap > macro with the double underscore squished, it is > simpler to just avoid this usage in the first place. >=20 > Signed-off-by: Daniel P. Berrange > --- > hw/scsi/spapr_vscsi.c | 2 +- > hw/scsi/trace-events | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) Reviewed-by: Stefan Hajnoczi --xgyAXRrhYN0wYx8y Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEcBAEBAgAGBQJX8lxaAAoJEJykq7OBq3PII/UIALCUH0V8lcBss/w8YDmYGApq OOgWrDNUliwmwjWFmk3qrf9hLwRxJqWXF2/jrQaWJZVFu78HTkaZwAdGc4H5OG1M /LplTeX0Eeu11ON4oAmQMcZfX/m0ehBJQXmlBWt5+I/P4rN8YJjwf+b1+hfYCCyM JkiY56IJQINE8NiiU21hu6O9vTDd2vYm5439fnkbnqRtk6zo8kGgrBBBuOCMgvnF X0G7fToWlx2g3mO5mb76DfSZINjnL7CjS4bgg407Opwc7FxJ8xJDqNIQMC6PiL+0 MIX+rK+XVQoqhe/4U/09V2aSKoI7qcBBvpja7TA13bgzMeMLi2wDqH9fodZhFv4= =I+zy -----END PGP SIGNATURE----- --xgyAXRrhYN0wYx8y--