From: Kevin Wolf <kwolf@redhat.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: "Tomáš Golembiovský" <tgolembi@redhat.com>,
qemu-devel@nongnu.org, qemu-block@nongnu.org,
"Max Reitz" <mreitz@redhat.com>
Subject: Re: [Qemu-devel] [PATCH] raw-posix: add 'offset' and 'size' options
Date: Tue, 4 Oct 2016 13:59:21 +0200 [thread overview]
Message-ID: <20161004115921.GF5316@noname.str.redhat.com> (raw)
In-Reply-To: <dc306851-88d9-d46c-82cc-b8eeca54578f@redhat.com>
Am 04.10.2016 um 12:12 hat Paolo Bonzini geschrieben:
>
>
> On 04/10/2016 11:24, Kevin Wolf wrote:
> > You also need to update the options for the blockdev-add QMP command in
> > qapi/block-core.json. The relevant type is BlockdevOptionsFile.
>
> Is it? Or should he define a new BlockdevOptionsRaw, and point to it in
> the BlockdevOptions union instead of "'raw':
> 'BlockdevOptionsGenericFormat'"?
It would be the right type for the raw-posix patch as it exists today.
But you're right that for adding the option to the raw format
driver, as we requested, a new BlockdevOptionsRaw (which inherits from
BlockdevOptionsGenericFormat) is needed.
Kevin
prev parent reply other threads:[~2016-10-04 11:59 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-02 19:13 [Qemu-devel] [PATCH] raw-posix: add 'offset' and 'size' options Tomáš Golembiovský
2016-10-03 8:52 ` Daniel P. Berrange
2016-10-03 9:20 ` Paolo Bonzini
2016-10-03 10:47 ` Tomáš Golembiovský
2016-10-03 11:20 ` Paolo Bonzini
2016-10-03 10:45 ` Tomáš Golembiovský
2016-10-03 10:52 ` Daniel P. Berrange
2016-10-03 11:07 ` Tomáš Golembiovský
2016-10-03 11:11 ` Daniel P. Berrange
2016-10-04 8:57 ` Kevin Wolf
2016-10-04 9:15 ` Daniel P. Berrange
2016-10-04 13:58 ` Eric Blake
2016-10-04 11:48 ` Tomáš Golembiovský
2016-10-03 15:28 ` Eric Blake
2016-10-04 9:24 ` Kevin Wolf
2016-10-04 10:12 ` Paolo Bonzini
2016-10-04 11:59 ` Kevin Wolf [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161004115921.GF5316@noname.str.redhat.com \
--to=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=tgolembi@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).