From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:49728) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1brONe-0004dx-OT for qemu-devel@nongnu.org; Tue, 04 Oct 2016 07:59:31 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1brONc-0000uW-TV for qemu-devel@nongnu.org; Tue, 04 Oct 2016 07:59:29 -0400 Date: Tue, 4 Oct 2016 13:59:21 +0200 From: Kevin Wolf Message-ID: <20161004115921.GF5316@noname.str.redhat.com> References: <598de7ff27e32fcb1b7f677f40fb8da4f0a1f512.1475434971.git.tgolembi@redhat.com> <20161004092405.GB5316@noname.str.redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Subject: Re: [Qemu-devel] [PATCH] raw-posix: add 'offset' and 'size' options List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: =?utf-8?B?VG9tw6HFoSBHb2xlbWJpb3Zza8O9?= , qemu-devel@nongnu.org, qemu-block@nongnu.org, Max Reitz Am 04.10.2016 um 12:12 hat Paolo Bonzini geschrieben: > > > On 04/10/2016 11:24, Kevin Wolf wrote: > > You also need to update the options for the blockdev-add QMP command in > > qapi/block-core.json. The relevant type is BlockdevOptionsFile. > > Is it? Or should he define a new BlockdevOptionsRaw, and point to it in > the BlockdevOptions union instead of "'raw': > 'BlockdevOptionsGenericFormat'"? It would be the right type for the raw-posix patch as it exists today. But you're right that for adding the option to the raw format driver, as we requested, a new BlockdevOptionsRaw (which inherits from BlockdevOptionsGenericFormat) is needed. Kevin