* [Qemu-devel] [PATCH 1/1] qemu-iotests: update test 085.out with correct output
@ 2016-10-04 17:22 Jeff Cody
2016-10-04 19:48 ` Eric Blake
0 siblings, 1 reply; 3+ messages in thread
From: Jeff Cody @ 2016-10-04 17:22 UTC (permalink / raw)
To: qemu-devel; +Cc: qemu-block, kwolf, famz, mreitz
Commit 5c678ee8d9406b9baeec788530965483575db555 changed the qmp
dispatch and validation code, and the error output that test
085 relied on changed. Update it to be correct.
Signed-off-by: Jeff Cody <jcody@redhat.com>
---
tests/qemu-iotests/085.out | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tests/qemu-iotests/085.out b/tests/qemu-iotests/085.out
index 08e4bb7..7a36117 100644
--- a/tests/qemu-iotests/085.out
+++ b/tests/qemu-iotests/085.out
@@ -20,7 +20,7 @@ Formatting 'TEST_DIR/1-snapshot-v0.qcow2', fmt=qcow2 size=134217728 backing_file
=== Invalid command - missing snapshot-file ===
-{"error": {"class": "GenericError", "desc": "Parameter 'snapshot-file' is missing"}}
+{"error": {"class": "GenericError", "desc": "Invalid parameter type for 'snapshot-file', expected: string"}}
=== Create several transactional group snapshots ===
--
2.7.4
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [Qemu-devel] [PATCH 1/1] qemu-iotests: update test 085.out with correct output
2016-10-04 17:22 [Qemu-devel] [PATCH 1/1] qemu-iotests: update test 085.out with correct output Jeff Cody
@ 2016-10-04 19:48 ` Eric Blake
2016-10-04 19:50 ` Jeff Cody
0 siblings, 1 reply; 3+ messages in thread
From: Eric Blake @ 2016-10-04 19:48 UTC (permalink / raw)
To: Jeff Cody, qemu-devel
Cc: kwolf, famz, qemu-block, mreitz, Marc-André Lureau,
Markus Armbruster
[-- Attachment #1: Type: text/plain, Size: 1301 bytes --]
On 10/04/2016 12:22 PM, Jeff Cody wrote:
> Commit 5c678ee8d9406b9baeec788530965483575db555 changed the qmp
> dispatch and validation code, and the error output that test
> 085 relied on changed. Update it to be correct.
>
> Signed-off-by: Jeff Cody <jcody@redhat.com>
> ---
> tests/qemu-iotests/085.out | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Doesn't Marc-Andre's regression-fix followup patch series change the
wording right back, so that we wouldn't need this fix?
https://lists.gnu.org/archive/html/qemu-devel/2016-09/msg08088.html
>
> diff --git a/tests/qemu-iotests/085.out b/tests/qemu-iotests/085.out
> index 08e4bb7..7a36117 100644
> --- a/tests/qemu-iotests/085.out
> +++ b/tests/qemu-iotests/085.out
> @@ -20,7 +20,7 @@ Formatting 'TEST_DIR/1-snapshot-v0.qcow2', fmt=qcow2 size=134217728 backing_file
>
> === Invalid command - missing snapshot-file ===
>
> -{"error": {"class": "GenericError", "desc": "Parameter 'snapshot-file' is missing"}}
> +{"error": {"class": "GenericError", "desc": "Invalid parameter type for 'snapshot-file', expected: string"}}
>
>
> === Create several transactional group snapshots ===
>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [Qemu-devel] [PATCH 1/1] qemu-iotests: update test 085.out with correct output
2016-10-04 19:48 ` Eric Blake
@ 2016-10-04 19:50 ` Jeff Cody
0 siblings, 0 replies; 3+ messages in thread
From: Jeff Cody @ 2016-10-04 19:50 UTC (permalink / raw)
To: Eric Blake
Cc: qemu-devel, kwolf, famz, qemu-block, mreitz,
Marc-André Lureau, Markus Armbruster
On Tue, Oct 04, 2016 at 02:48:41PM -0500, Eric Blake wrote:
> On 10/04/2016 12:22 PM, Jeff Cody wrote:
> > Commit 5c678ee8d9406b9baeec788530965483575db555 changed the qmp
> > dispatch and validation code, and the error output that test
> > 085 relied on changed. Update it to be correct.
> >
> > Signed-off-by: Jeff Cody <jcody@redhat.com>
> > ---
> > tests/qemu-iotests/085.out | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
>
> Doesn't Marc-Andre's regression-fix followup patch series change the
> wording right back, so that we wouldn't need this fix?
>
> https://lists.gnu.org/archive/html/qemu-devel/2016-09/msg08088.html
>
Ah, yes - thanks. Please ignore this patch :)
> >
> > diff --git a/tests/qemu-iotests/085.out b/tests/qemu-iotests/085.out
> > index 08e4bb7..7a36117 100644
> > --- a/tests/qemu-iotests/085.out
> > +++ b/tests/qemu-iotests/085.out
> > @@ -20,7 +20,7 @@ Formatting 'TEST_DIR/1-snapshot-v0.qcow2', fmt=qcow2 size=134217728 backing_file
> >
> > === Invalid command - missing snapshot-file ===
> >
> > -{"error": {"class": "GenericError", "desc": "Parameter 'snapshot-file' is missing"}}
> > +{"error": {"class": "GenericError", "desc": "Invalid parameter type for 'snapshot-file', expected: string"}}
> >
> >
> > === Create several transactional group snapshots ===
> >
>
> --
> Eric Blake eblake redhat com +1-919-301-3266
> Libvirt virtualization library http://libvirt.org
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-10-04 19:50 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-10-04 17:22 [Qemu-devel] [PATCH 1/1] qemu-iotests: update test 085.out with correct output Jeff Cody
2016-10-04 19:48 ` Eric Blake
2016-10-04 19:50 ` Jeff Cody
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).