From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:60945)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <cota@braap.org>) id 1brZfd-0006NS-1A
	for qemu-devel@nongnu.org; Tue, 04 Oct 2016 20:02:50 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <cota@braap.org>) id 1brZfZ-0006Vb-Ss
	for qemu-devel@nongnu.org; Tue, 04 Oct 2016 20:02:48 -0400
Received: from out4-smtp.messagingengine.com ([66.111.4.28]:58399)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <cota@braap.org>) id 1brZfX-0006Qm-JL
	for qemu-devel@nongnu.org; Tue, 04 Oct 2016 20:02:45 -0400
Date: Tue, 4 Oct 2016 20:02:29 -0400
From: "Emilio G. Cota" <cota@braap.org>
Message-ID: <20161005000229.GA1744@flamenco>
References: <1474048017-26696-1-git-send-email-rth@twiddle.net>
	<1474048017-26696-14-git-send-email-rth@twiddle.net>
	<8760p9te18.fsf@linaro.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <8760p9te18.fsf@linaro.org>
Subject: Re: [Qemu-devel] [PATCH v4 13/35] tcg: Add atomic helpers
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel/>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Alex =?iso-8859-1?Q?Benn=E9e?= <alex.bennee@linaro.org>
Cc: Richard Henderson <rth@twiddle.net>, qemu-devel@nongnu.org

On Mon, Oct 03, 2016 at 20:42:43 +0100, Alex Bennée wrote:
> 
> Richard Henderson <rth@twiddle.net> writes:
> 
> > Add all of cmpxchg, op_fetch, fetch_op, and xchg.
> > Handle both endian-ness, and sizes up to 8.
> > Handle expanding non-atomically, when emulating in serial.
> >
> > Signed-off-by: Richard Henderson <rth@twiddle.net>
> > ---
> <snip>
> > diff --git a/tcg/tcg-op.c b/tcg/tcg-op.c
> > index 291d50b..65e3663 100644
> > --- a/tcg/tcg-op.c
> > +++ b/tcg/tcg-op.c
> <snip>
> > +void tcg_gen_atomic_cmpxchg_i32(TCGv_i32 retv, TCGv addr, TCGv_i32 cmpv,
> > +                                TCGv_i32 newv, TCGArg idx, TCGMemOp memop)
> > +{
> > +    memop = tcg_canonicalize_memop(memop, 0, 0);
> > +
> > +    if (!parallel_cpus) {
> 
> This breaks the compile because parallel_cpus isn't visible to the
> function. However I suspect it's because there is a missing patch in
> this series (I checked my email and the archive). What happened to 06/35?

It doesn't break the build for me--but I'm grabbing the series from github.

I think 06/35 was meant to be this patch:
  https://github.com/rth7680/qemu/commit/fab3abe9220

The whole series is here:
  https://github.com/rth7680/qemu/tree/atomic-4

		Emilio