qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Andrew Jones <drjones@redhat.com>
To: Wei Huang <wei@redhat.com>
Cc: qemu-arm@nongnu.org, peter.maydell@linaro.org,
	qemu-devel@nongnu.org, abologna@redhat.com,
	shannon.zhao@linaro.org
Subject: Re: [Qemu-devel] [PATCH V6 1/2] arm64: Add an option to turn on/off vPMU support
Date: Wed, 5 Oct 2016 09:10:10 +0200	[thread overview]
Message-ID: <20161005071010.gesdbmv4l34edbkm@hawk.localdomain> (raw)
In-Reply-To: <1475617134-28180-2-git-send-email-wei@redhat.com>

On Tue, Oct 04, 2016 at 05:38:53PM -0400, Wei Huang wrote:
> This patch adds a pmu=[on/off] option to enable/disable vPMU support
> in guest vCPU. This option is only available for cortex-a57/cortex-53/
> host under both TCG and KVM modes, but unavailable on ARMv7 and other
> processors. It allows virt tools, such as libvirt, to determine the
> exsitence of vPMU and configure it. Note that, if nothing specified,
> the pmu option is set to AUTO as default, allowing machine-level PMU
> property to override it. Also when pmu is turned on under non-KVM mode,
> a warning message will be printed.
> 
> Signed-off-by: Wei Huang <wei@redhat.com>
> ---
>  hw/arm/virt-acpi-build.c |  2 +-
>  hw/arm/virt.c            |  2 +-
>  target-arm/cpu.c         | 23 +++++++++++++++++++++++
>  target-arm/cpu.h         |  3 ++-
>  target-arm/cpu64.c       |  2 ++
>  target-arm/kvm64.c       | 17 ++++++++++++++---
>  6 files changed, 43 insertions(+), 6 deletions(-)
>

Please leave r-b's on patches that don't change. afaict this one
didn't change, so [again]

Reviewed-by: Andrew Jones <drjones@redhat.com> 

  reply	other threads:[~2016-10-05  7:10 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-10-04 21:38 [Qemu-devel] [PATCH V6 0/2] Add option to configure guest vPMU Wei Huang
2016-10-04 21:38 ` [Qemu-devel] [PATCH V6 1/2] arm64: Add an option to turn on/off vPMU support Wei Huang
2016-10-05  7:10   ` Andrew Jones [this message]
2016-10-06 17:43   ` Andrea Bolognani
2016-10-04 21:38 ` [Qemu-devel] [PATCH V6 2/2] arm: virt: add PMU property to mach-virt machine type Wei Huang
2016-10-05  7:15   ` Andrew Jones
2016-10-06 17:44   ` Andrea Bolognani
2016-10-04 21:53 ` [Qemu-devel] [Qemu-arm] [PATCH V6 0/2] Add option to configure guest vPMU Wei Huang
2016-10-13 16:19 ` [Qemu-devel] " Peter Maydell
2016-10-14  7:48   ` Andrew Jones
2016-10-18 17:16     ` Andrew Jones
2016-10-18 17:22       ` Peter Maydell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20161005071010.gesdbmv4l34edbkm@hawk.localdomain \
    --to=drjones@redhat.com \
    --cc=abologna@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-arm@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    --cc=shannon.zhao@linaro.org \
    --cc=wei@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).