From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:44464) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1brgLP-0005dl-7z for qemu-devel@nongnu.org; Wed, 05 Oct 2016 03:10:24 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1brgLO-0002f2-9A for qemu-devel@nongnu.org; Wed, 05 Oct 2016 03:10:23 -0400 Date: Wed, 5 Oct 2016 09:10:10 +0200 From: Andrew Jones Message-ID: <20161005071010.gesdbmv4l34edbkm@hawk.localdomain> References: <1475617134-28180-1-git-send-email-wei@redhat.com> <1475617134-28180-2-git-send-email-wei@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1475617134-28180-2-git-send-email-wei@redhat.com> Subject: Re: [Qemu-devel] [PATCH V6 1/2] arm64: Add an option to turn on/off vPMU support List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Wei Huang Cc: qemu-arm@nongnu.org, peter.maydell@linaro.org, qemu-devel@nongnu.org, abologna@redhat.com, shannon.zhao@linaro.org On Tue, Oct 04, 2016 at 05:38:53PM -0400, Wei Huang wrote: > This patch adds a pmu=[on/off] option to enable/disable vPMU support > in guest vCPU. This option is only available for cortex-a57/cortex-53/ > host under both TCG and KVM modes, but unavailable on ARMv7 and other > processors. It allows virt tools, such as libvirt, to determine the > exsitence of vPMU and configure it. Note that, if nothing specified, > the pmu option is set to AUTO as default, allowing machine-level PMU > property to override it. Also when pmu is turned on under non-KVM mode, > a warning message will be printed. > > Signed-off-by: Wei Huang > --- > hw/arm/virt-acpi-build.c | 2 +- > hw/arm/virt.c | 2 +- > target-arm/cpu.c | 23 +++++++++++++++++++++++ > target-arm/cpu.h | 3 ++- > target-arm/cpu64.c | 2 ++ > target-arm/kvm64.c | 17 ++++++++++++++--- > 6 files changed, 43 insertions(+), 6 deletions(-) > Please leave r-b's on patches that don't change. afaict this one didn't change, so [again] Reviewed-by: Andrew Jones