From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:37245) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1briAT-0000MP-HQ for qemu-devel@nongnu.org; Wed, 05 Oct 2016 05:07:14 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1briAO-0007RF-DL for qemu-devel@nongnu.org; Wed, 05 Oct 2016 05:07:12 -0400 Received: from mx1.redhat.com ([209.132.183.28]:50582) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1briAO-0007RA-6P for qemu-devel@nongnu.org; Wed, 05 Oct 2016 05:07:08 -0400 Date: Wed, 5 Oct 2016 10:07:03 +0100 From: "Dr. David Alan Gilbert" Message-ID: <20161005090703.GB2036@work-vm> References: <1474658044-9479-1-git-send-email-dgilbert@redhat.com> <8737kbw4sg.fsf@emacs.mitica> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <8737kbw4sg.fsf@emacs.mitica> Subject: Re: [Qemu-devel] [PATCH 0/3] RDMA error handling List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Juan Quintela Cc: qemu-devel@nongnu.org, amit.shah@redhat.com, michael@hinespot.com * Juan Quintela (quintela@redhat.com) wrote: > "Dr. David Alan Gilbert (git)" wrote: > > From: "Dr. David Alan Gilbert" > > > > lp: https://bugs.launchpad.net/qemu/+bug/1545052 > > > > The RDMA code tends to hang if the destination dies > > in the wrong place; this series doesn't completely fix > > that, but in cases where the destination knows there's > > been an error, it makes sure it tells the source and > > that cleans up quickly. > > If the destination just dies, then the source still hangs > > and I still need to look at better ways to fix that. > > > > Dave > > > > Dr. David Alan Gilbert (3): > > migration/rdma: Pass qemu_file errors across link > > migration: Make failed migration load set file error > > migration/rdma: Don't flag an error when we've been told about one > > > > migration/rdma.c | 9 ++++++++- > > migration/savevm.c | 19 ++++++++++++------- > > 2 files changed, 20 insertions(+), 8 deletions(-) > > > Reviewed-by: Juan Quintela > > and applied. > Thanks. > BTW, second patch is not RDMA error handling O:-) Ah, but it's there to cause the first patch to trigger. It's not needed in the case of any of the other transports. Dave -- Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK