* [Qemu-devel] [PATCH] block: use bdrv_add_before_write_notifier
@ 2016-10-04 8:49 Paolo Bonzini
2016-10-04 20:03 ` Eric Blake
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Paolo Bonzini @ 2016-10-04 8:49 UTC (permalink / raw)
To: qemu-devel; +Cc: qemu-block
Register the notifier using the specific API for block devices.
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
---
block/write-threshold.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/block/write-threshold.c b/block/write-threshold.c
index cc2ca71..0bd1a01 100644
--- a/block/write-threshold.c
+++ b/block/write-threshold.c
@@ -76,8 +76,7 @@ static int coroutine_fn before_write_notify(NotifierWithReturn *notifier,
static void write_threshold_register_notifier(BlockDriverState *bs)
{
bs->write_threshold_notifier.notify = before_write_notify;
- notifier_with_return_list_add(&bs->before_write_notifiers,
- &bs->write_threshold_notifier);
+ bdrv_add_before_write_notifier(bs, &bs->write_threshold_notifier);
}
static void write_threshold_update(BlockDriverState *bs,
--
2.7.4
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [Qemu-devel] [PATCH] block: use bdrv_add_before_write_notifier
2016-10-04 8:49 [Qemu-devel] [PATCH] block: use bdrv_add_before_write_notifier Paolo Bonzini
@ 2016-10-04 20:03 ` Eric Blake
2016-10-05 9:44 ` [Qemu-devel] [Qemu-block] " Kevin Wolf
2016-10-05 13:58 ` Stefan Hajnoczi
2 siblings, 0 replies; 4+ messages in thread
From: Eric Blake @ 2016-10-04 20:03 UTC (permalink / raw)
To: Paolo Bonzini, qemu-devel; +Cc: qemu-block
[-- Attachment #1: Type: text/plain, Size: 1122 bytes --]
On 10/04/2016 03:49 AM, Paolo Bonzini wrote:
> Register the notifier using the specific API for block devices.
>
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> ---
> block/write-threshold.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
Reviewed-by: Eric Blake <eblake@redhat.com>
>
> diff --git a/block/write-threshold.c b/block/write-threshold.c
> index cc2ca71..0bd1a01 100644
> --- a/block/write-threshold.c
> +++ b/block/write-threshold.c
> @@ -76,8 +76,7 @@ static int coroutine_fn before_write_notify(NotifierWithReturn *notifier,
> static void write_threshold_register_notifier(BlockDriverState *bs)
> {
> bs->write_threshold_notifier.notify = before_write_notify;
> - notifier_with_return_list_add(&bs->before_write_notifiers,
> - &bs->write_threshold_notifier);
> + bdrv_add_before_write_notifier(bs, &bs->write_threshold_notifier);
> }
>
> static void write_threshold_update(BlockDriverState *bs,
>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [Qemu-devel] [Qemu-block] [PATCH] block: use bdrv_add_before_write_notifier
2016-10-04 8:49 [Qemu-devel] [PATCH] block: use bdrv_add_before_write_notifier Paolo Bonzini
2016-10-04 20:03 ` Eric Blake
@ 2016-10-05 9:44 ` Kevin Wolf
2016-10-05 13:58 ` Stefan Hajnoczi
2 siblings, 0 replies; 4+ messages in thread
From: Kevin Wolf @ 2016-10-05 9:44 UTC (permalink / raw)
To: Paolo Bonzini; +Cc: qemu-devel, qemu-block
Am 04.10.2016 um 10:49 hat Paolo Bonzini geschrieben:
> Register the notifier using the specific API for block devices.
>
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
Thanks, applied to the block branch.
Kevin
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Qemu-devel] [Qemu-block] [PATCH] block: use bdrv_add_before_write_notifier
2016-10-04 8:49 [Qemu-devel] [PATCH] block: use bdrv_add_before_write_notifier Paolo Bonzini
2016-10-04 20:03 ` Eric Blake
2016-10-05 9:44 ` [Qemu-devel] [Qemu-block] " Kevin Wolf
@ 2016-10-05 13:58 ` Stefan Hajnoczi
2 siblings, 0 replies; 4+ messages in thread
From: Stefan Hajnoczi @ 2016-10-05 13:58 UTC (permalink / raw)
To: Paolo Bonzini; +Cc: qemu-devel, qemu-block
[-- Attachment #1: Type: text/plain, Size: 337 bytes --]
On Tue, Oct 04, 2016 at 10:49:43AM +0200, Paolo Bonzini wrote:
> Register the notifier using the specific API for block devices.
>
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> ---
> block/write-threshold.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 455 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2016-10-05 13:58 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-10-04 8:49 [Qemu-devel] [PATCH] block: use bdrv_add_before_write_notifier Paolo Bonzini
2016-10-04 20:03 ` Eric Blake
2016-10-05 9:44 ` [Qemu-devel] [Qemu-block] " Kevin Wolf
2016-10-05 13:58 ` Stefan Hajnoczi
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).