From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:53120) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1brmmk-0002U0-01 for qemu-devel@nongnu.org; Wed, 05 Oct 2016 10:03:02 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1brmmh-0006gc-W1 for qemu-devel@nongnu.org; Wed, 05 Oct 2016 10:03:00 -0400 Date: Wed, 5 Oct 2016 16:02:51 +0200 From: Kevin Wolf Message-ID: <20161005140251.GC1657@noname.str.redhat.com> References: <1475272849-19990-1-git-send-email-jsnow@redhat.com> <1475272849-19990-5-git-send-email-jsnow@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1475272849-19990-5-git-send-email-jsnow@redhat.com> Subject: Re: [Qemu-devel] [PATCH v2 04/11] blockjobs: Always use block_job_get_aio_context List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: John Snow Cc: qemu-block@nongnu.org, vsementsov@virtuozzo.com, famz@redhat.com, stefanha@redhat.com, jcody@redhat.com, eblake@redhat.com, qemu-devel@nongnu.org Am 01.10.2016 um 00:00 hat John Snow geschrieben: > There are a few places where we're fishing it out for ourselves. > Let's not do that and instead use the helper. > > Signed-off-by: John Snow That change makes a difference when the block job is running its completion part after block_job_defer_to_main_loop(). The commit message could be more explicit about whether this is intentional or whether this case is expected to happen at all. I suspect that if it can happen, this is a bug fix. Please check and update the commit message accordingly. Kevin