From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:41440) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1brlzj-0006ct-TQ for qemu-devel@nongnu.org; Wed, 05 Oct 2016 09:12:25 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1brlzf-0005k1-Jy for qemu-devel@nongnu.org; Wed, 05 Oct 2016 09:12:22 -0400 Received: from 17.mo6.mail-out.ovh.net ([46.105.36.150]:43647) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1brlzf-0005ju-Dx for qemu-devel@nongnu.org; Wed, 05 Oct 2016 09:12:19 -0400 Received: from player738.ha.ovh.net (b7.ovh.net [213.186.33.57]) by mo6.mail-out.ovh.net (Postfix) with ESMTP id D19972BF55 for ; Wed, 5 Oct 2016 15:12:17 +0200 (CEST) Date: Wed, 5 Oct 2016 15:12:13 +0200 From: Greg Kurz Message-ID: <20161005151213.542393c3@bahia> In-Reply-To: <20160927100853.GD563@stefanha-x1.localdomain> References: <1474291685-24226-1-git-send-email-stefanha@redhat.com> <20160927100853.GD563@stefanha-x1.localdomain> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; boundary="Sig_/bxVqWVqRckED=qjuMHm.5b_"; protocol="application/pgp-signature" Subject: Re: [Qemu-devel] [PATCH 0/3] virtio: detach VirtQueueElements freed by reset List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Michael S. Tsirkin" Cc: Stefan Hajnoczi , lprosek@redhat.com, qemu-devel@nongnu.org --Sig_/bxVqWVqRckED=qjuMHm.5b_ Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable On Tue, 27 Sep 2016 11:08:53 +0100 Stefan Hajnoczi wrote: > On Mon, Sep 19, 2016 at 02:28:02PM +0100, Stefan Hajnoczi wrote: > > virtio-blk and virtio-serial need to free VirtQueueElements during devi= ce > > reset. Simply calling g_free(elem) is not enough because the scatter-g= ather > > list should be unmapped and vq->inuse must be decremented. > >=20 > > These patches address the issue. I am not including a patch that chang= es > > vq->inuse =3D 0 to assert(!vq->inuse) in virtio_reset() yet because vir= tio-9p, > > virtio-gpu, and virtio-net have code paths that do not decrement vq->in= use. > >=20 > > Stefan Hajnoczi (3): > > virtio: add virtio_detach_element() > > virtio-blk: add missing virtio_detach_element() call > > virtio-serial: add missing virtio_detach_element() call > >=20 > > hw/block/virtio-blk.c | 1 + > > hw/char/virtio-serial-bus.c | 14 ++++++++++++++ > > hw/virtio/virtio.c | 27 +++++++++++++++++++++++++-- > > include/hw/virtio/virtio.h | 2 ++ > > 4 files changed, 42 insertions(+), 2 deletions(-) =20 >=20 > Ping? +1 because patch 1/3 of this series is required by: Subject: [PATCH v4 0/9] virtio: avoid inappropriate QEMU termination in dev= ice code Date: Fri, 30 Sep 2016 17:12:32 +0200 Message-Id: <147524835229.953.16853431367911587573.stgit@bahia> Cheers. -- Greg --Sig_/bxVqWVqRckED=qjuMHm.5b_ Content-Type: application/pgp-signature Content-Description: OpenPGP digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iEYEARECAAYFAlf0/C0ACgkQAvw66wEB28LpLwCdGpceVREGhjwk1veAkqx/hmhg fSgAoJwnHIiRtU+guB4vSMcxVHwMPMXb =89LK -----END PGP SIGNATURE----- --Sig_/bxVqWVqRckED=qjuMHm.5b_--