qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Stefan Hajnoczi <stefanha@redhat.com>
To: "Daniel P. Berrange" <berrange@redhat.com>
Cc: qemu-devel@nongnu.org, "Lluís Vilanova" <vilanova@ac.upc.edu>
Subject: Re: [Qemu-devel] [PATCH v6 00/20] Refactor trace to allow modular build
Date: Wed, 5 Oct 2016 16:31:27 +0100	[thread overview]
Message-ID: <20161005153127.GA30075@stefanha-x1.localdomain> (raw)
In-Reply-To: <1475588159-30598-1-git-send-email-berrange@redhat.com>

[-- Attachment #1: Type: text/plain, Size: 3010 bytes --]

Hmm...the SystemTap simpletrace script does not work anymore for me.  But I've
tested qemu.git/master and get the same results.

Did you test it successfully somehow?

$ cat x86_64-softmmu/qemu-system-x86_64.stp \
      x86_64-softmmu/qemu-system-x86_64-simpletrace.stp >test.stp
$ echo 'probe qemu.system.x86_64.simpletrace.* {}' >>test.stp

$ sudo stap test.stp -c 'x86_64-softmmu/qemu-system-x86_64 -enable-kvm' >/tmp/trace.dat

$ scripts/simpletrace.py trace-events-all /tmp/trace.dat
Traceback (most recent call last):
  File "scripts/simpletrace.py", line 217, in <module>
    run(Formatter())
  File "scripts/simpletrace.py", line 192, in run
    process(events, sys.argv[2], analyzer, read_header=read_header)
  File "scripts/simpletrace.py", line 167, in process
    for rec in read_trace_records(edict, log):
  File "scripts/simpletrace.py", line 103, in read_trace_records
    rec = read_record(edict, idtoname, fobj)
  File "scripts/simpletrace.py", line 71, in read_record
    return get_record(edict, idtoname, rechdr, fobj)
  File "scripts/simpletrace.py", line 43, in get_record
    name = idtoname[event_id]
KeyError: 1475680158726993795

$ scripts/simpletrace.py --no-header trace-events-all /tmp/trace.dat
Traceback (most recent call last):
  File "scripts/simpletrace.py", line 217, in <module>
    run(Formatter())
  File "scripts/simpletrace.py", line 192, in run
    process(events, sys.argv[2], analyzer, read_header=read_header)
  File "scripts/simpletrace.py", line 167, in process
    for rec in read_trace_records(edict, log):
  File "scripts/simpletrace.py", line 103, in read_trace_records
    rec = read_record(edict, idtoname, fobj)
  File "scripts/simpletrace.py", line 71, in read_record
    return get_record(edict, idtoname, rechdr, fobj)
  File "scripts/simpletrace.py", line 43, in get_record
    name = idtoname[event_id]
KeyError: 17487890541996943796L

$ xxd -l 256 /tmp/trace.dat
00000000: ffff ffff ffff ffff b429 a40a cb77 b1f2  .........)...w..
00000010: 0400 0000 0000 0000 3005 0000 0000 0000  ........0.......
00000020: 83b7 032f 49ab 7a14 5b00 0000 e674 0000  .../I.z.[....t..
00000030: 0600 0000 6465 7669 6365 0600 0000 6465  ....device....de
00000040: 7669 6365 0e00 0000 6877 2f63 6f72 652f  vice....hw/core/
00000050: 7164 6576 2e63 6504 0000 0000 0000 1100  qdev.ce.........
00000060: 0000 6465 7669 6365 5f63 6c61 7373 5f69  ..device_class_i
00000070: 6e69 7400 0000 0000 0000 0000 0000 0000  nit.............
00000080: 0000 0020 0000 006f 626a 6563 745f 636c  ... ...object_cl
00000090: 6173 735f 6479 6e61 6d69 635f 6361 7374  ass_dynamic_cast
000000a0: 5f61 7373 6572 7401 0000 0000 0000 0000  _assert.........
000000b0: 0000 0000 0000 00a7 ca03 2f49 ab7a 145b  ........../I.z.[
000000c0: 0000 00e6 7400 0006 0000 0064 6576 6963  ....t......devic
000000d0: 6506 0000 0064 6576 6963 650e 0000 0068  e....device....h
000000e0: 772f 636f 7265 2f71 6465 762e 6365 0400  w/core/qdev.ce..
000000f0: 0000 0000 0011 0000 0064 6576 6963 655f  .........device_

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 455 bytes --]

  parent reply	other threads:[~2016-10-05 15:31 UTC|newest]

Thread overview: 33+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-10-04 13:35 [Qemu-devel] [PATCH v6 00/20] Refactor trace to allow modular build Daniel P. Berrange
2016-10-04 13:35 ` [Qemu-devel] [PATCH v6 01/20] trace: move colo trace events to net/ sub-directory Daniel P. Berrange
2016-10-04 13:35 ` [Qemu-devel] [PATCH v6 02/20] trace: remove double-underscore in event name Daniel P. Berrange
2016-10-04 13:35 ` [Qemu-devel] [PATCH v6 03/20] trace: add trace event iterator APIs Daniel P. Berrange
2016-10-04 13:35 ` [Qemu-devel] [PATCH v6 04/20] trace: convert code to use event iterators Daniel P. Berrange
2016-10-05  9:48   ` Lluís Vilanova
2016-10-04 13:35 ` [Qemu-devel] [PATCH v6 05/20] trace: remove some now unused functions Daniel P. Berrange
2016-10-04 13:35 ` [Qemu-devel] [PATCH v6 06/20] trace: remove global 'uint16 dstate[]' array Daniel P. Berrange
2016-10-04 13:35 ` [Qemu-devel] [PATCH v6 07/20] trace: remove duplicate control.h includes in generated-tracers.h Daniel P. Berrange
2016-10-04 13:35 ` [Qemu-devel] [PATCH v6 08/20] trace: break circular dependency in event-internal.h Daniel P. Berrange
2016-10-04 13:35 ` [Qemu-devel] [PATCH v6 09/20] trace: give each trace event a named TraceEvent struct Daniel P. Berrange
2016-10-04 13:35 ` [Qemu-devel] [PATCH v6 10/20] trace: remove the TraceEventID and TraceEventVCPUID enums Daniel P. Berrange
2016-10-04 13:35 ` [Qemu-devel] [PATCH v6 11/20] trace: emit name <-> ID mapping in simpletrace header Daniel P. Berrange
2016-10-05 14:09   ` Stefan Hajnoczi
2016-10-04 13:35 ` [Qemu-devel] [PATCH v6 12/20] trace: don't abort qemu if ftrace can't be initialized Daniel P. Berrange
2016-10-04 20:12   ` Eric Blake
2016-10-05 15:39     ` Stefan Hajnoczi
2016-10-04 13:35 ` [Qemu-devel] [PATCH v6 13/20] trace: provide mechanism for registering trace events Daniel P. Berrange
2016-10-04 13:35 ` [Qemu-devel] [PATCH v6 14/20] trace: dynamically allocate trace_dstate in CPUState Daniel P. Berrange
2016-10-04 13:35 ` [Qemu-devel] [PATCH v6 15/20] trace: dynamically allocate event IDs at runtime Daniel P. Berrange
2016-10-04 13:35 ` [Qemu-devel] [PATCH v6 16/20] trace: get rid of generated-events.h/generated-events.c Daniel P. Berrange
2016-10-04 13:35 ` [Qemu-devel] [PATCH v6 17/20] trace: rename _read_events to read_events Daniel P. Berrange
2016-10-04 13:35 ` [Qemu-devel] [PATCH v6 18/20] trace: push reading of events up a level to tracetool main Daniel P. Berrange
2016-10-04 13:35 ` [Qemu-devel] [PATCH v6 19/20] trace: pass trace-events to tracetool as a positional param Daniel P. Berrange
2016-10-04 13:35 ` [Qemu-devel] [PATCH v6 20/20] trace: introduce a formal group name for trace events Daniel P. Berrange
2016-10-05  9:53   ` Lluís Vilanova
2016-10-05 15:31 ` Stefan Hajnoczi [this message]
2016-10-06  8:21   ` [Qemu-devel] [PATCH v6 00/20] Refactor trace to allow modular build Daniel P. Berrange
2016-10-06  9:12   ` Daniel P. Berrange
2016-10-05 15:32 ` Stefan Hajnoczi
2016-10-07 13:51 ` [Qemu-devel] [PATCH v6 21/20] linux-user/bsd-user: initialize trace events subsystem Daniel P. Berrange
2016-10-07 14:14   ` Daniel P. Berrange
2016-10-12  7:50   ` Stefan Hajnoczi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20161005153127.GA30075@stefanha-x1.localdomain \
    --to=stefanha@redhat.com \
    --cc=berrange@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=vilanova@ac.upc.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).