From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:48398) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1broIX-0003KJ-6p for qemu-devel@nongnu.org; Wed, 05 Oct 2016 11:39:58 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1broIS-00076f-7A for qemu-devel@nongnu.org; Wed, 05 Oct 2016 11:39:56 -0400 Received: from mx1.redhat.com ([209.132.183.28]:43828) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1broIS-00076Q-0u for qemu-devel@nongnu.org; Wed, 05 Oct 2016 11:39:52 -0400 Date: Wed, 5 Oct 2016 16:39:49 +0100 From: Stefan Hajnoczi Message-ID: <20161005153949.GC30075@stefanha-x1.localdomain> References: <1475588159-30598-1-git-send-email-berrange@redhat.com> <1475588159-30598-13-git-send-email-berrange@redhat.com> <0121cfb3-77cf-d983-3c6a-a7f8a7b0acbd@redhat.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="0lnxQi9hkpPO77W3" Content-Disposition: inline In-Reply-To: <0121cfb3-77cf-d983-3c6a-a7f8a7b0acbd@redhat.com> Subject: Re: [Qemu-devel] [PATCH v6 12/20] trace: don't abort qemu if ftrace can't be initialized List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eric Blake Cc: "Daniel P. Berrange" , qemu-devel@nongnu.org, =?iso-8859-1?Q?Llu=EDs?= Vilanova --0lnxQi9hkpPO77W3 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Oct 04, 2016 at 03:12:31PM -0500, Eric Blake wrote: > On 10/04/2016 08:35 AM, Daniel P. Berrange wrote: > > If the ftrace backend is compiled into QEMU, any attempt > > to start QEMU while non-root will fail due to the > > inability to open /sys/kernel/debug/tracing/tracing_on. > >=20 > > Add a fallback into the code so that it connects up the > > trace_marker_fd variable to /dev/null when setting >=20 > s/setting/getting/ ? >=20 > > EACCESS on the 'trace_on' file. This allows QEMU to >=20 > s/EACCESS/EACCES/ Thanks, I've applied these changes while merging. Stefan --0lnxQi9hkpPO77W3 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEcBAEBAgAGBQJX9R7FAAoJEJykq7OBq3PIB/cH/1wXAx5F1dP/qvGHXIx1xxSH h5fJK43XxP1588h/q5hbb9T4NdDMcijf00m+kYuUJtBFhYKqBIUUmZLSF2YJHzJI 9UHWvqIQA5nFhwODcukz3vI8/lyFr+b4mSk8jNLUFMlMHahHPOb1TD2WQ6JR3/g/ Tioo6+yOdZamV93tQxa4kQqOsFGgLs+wqNGZoXirlQD6EexN3ZTUCRoi9Ai7MA1R q8+dih+oMdSD5AuZE/f2v1BModkAoAGEmZwJaTbGm10RGRUZECLe137dzpNm22jX 4qcSY8vbaVVFdOxOs4tJl9zhv7Oj0ofuz+bTVp6kEalA7zocMj1LLVt8B+zr+c8= =4pLR -----END PGP SIGNATURE----- --0lnxQi9hkpPO77W3--