From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:47819)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rkrcmar@redhat.com>) id 1bsB6R-0001YN-R4
	for qemu-devel@nongnu.org; Thu, 06 Oct 2016 12:01:00 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <rkrcmar@redhat.com>) id 1bsB6O-0001xt-L6
	for qemu-devel@nongnu.org; Thu, 06 Oct 2016 12:00:59 -0400
Received: from mx1.redhat.com ([209.132.183.28]:41702)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rkrcmar@redhat.com>) id 1bsB6O-0001xi-Er
	for qemu-devel@nongnu.org; Thu, 06 Oct 2016 12:00:56 -0400
Date: Thu, 6 Oct 2016 18:00:52 +0200
From: Radim =?utf-8?B?S3LEjW3DocWZ?= <rkrcmar@redhat.com>
Message-ID: <20161006160051.GC19924@potion>
References: <20161005130657.3399-1-rkrcmar@redhat.com>
	<20161005130657.3399-8-rkrcmar@redhat.com>
	<20161006145142.GR3877@thinpad.lan.raisama.net>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <20161006145142.GR3877@thinpad.lan.raisama.net>
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH v4 7/8] intel_iommu: keep buggy EIM enabled
 in 2.7 machine type
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel/>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Eduardo Habkost <ehabkost@redhat.com>
Cc: qemu-devel@nongnu.org, Peter Xu <peterx@redhat.com>, Igor Mammedov <imammedo@redhat.com>, Paolo Bonzini <pbonzini@redhat.com>, Richard Henderson <rth@twiddle.net>, "Michael S. Tsirkin" <mst@redhat.com>

2016-10-06 11:51-0300, Eduardo Habkost:
> On Wed, Oct 05, 2016 at 03:06:56PM +0200, Radim Kr=C4=8Dm=C3=A1=C5=99 w=
rote:
>> Signed-off-by: Radim Kr=C4=8Dm=C3=A1=C5=99 <rkrcmar@redhat.com>
>> ---
>> diff --git a/hw/i386/intel_iommu.c b/hw/i386/intel_iommu.c
>> @@ -2015,6 +2015,7 @@ static Property vtd_properties[] =3D {
>>      DEFINE_PROP_UINT32("version", IntelIOMMUState, version, 0),
>>      DEFINE_PROP_ON_OFF_AUTO("eim", IntelIOMMUState, intr_eim,
>>                              ON_OFF_AUTO_AUTO),
>> +    DEFINE_PROP_BOOL("buggy_eim", IntelIOMMUState, buggy_eim, false),
>=20
> I suggest "buggy-eim", to follow the usual style for QOM property
> names.
>=20
> Assuming the name gets changed:
>=20
> Reviewed-by: Eduardo Habkost <ehabkost@redhat.com>

I'll change the name to "x-buggy-eim" and also squash the patch with
[6/8] as the property doesn't seem to be hated too much.

It's going to be a different patch, so I'll drop the r-b by default,
sorry.