Re: [Qemu-devel] Monitor brain dump

[Kevin Wolf <kwolf@redhat.com>]

Am 06.10.2016 um 13:07 hat Paolo Bonzini geschrieben:
> On 05/10/2016 19:43, Dr. David Alan Gilbert wrote:
> > > Speaking of the pocket calculator: my recommendation would be "nuke from
> > > orbit".  It adds surprising corner cases to the HMP language, and
> > > provides next to no value.
> > 
> > Huh, didn't realise that existed - I assume you mean get_expr and friends?
> > yep sounds nukable
> 
> We've been suggesting commands like "x/10i $pc-20" to people who
> reported emulation failures in KVM, so there is some benefit in that.

Yes, there are some operations that it supports that I think are really
rarely used (I don't think I've ever used modulo in the monitor), but
using the register variables like $pc or calculating offsets (i.e. sums
and possibly multiplications) is fairly common and useful for debugging
guests.

Looking at git blame, this seems to be something that just works and is
hardly ever touched, so why does leaving it there hurt us?

Any examples of the surprising corner cases? Can they be addressed
without removing the useful parts of it?

> My hunch is that it would be a drop in the sea if monitor.c were
> refactored properly.  Now that QMP middle mode is gone it should be much
> easier.

That, too.

Kevin