From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:44527) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bsS6c-0004CF-64 for qemu-devel@nongnu.org; Fri, 07 Oct 2016 06:10:19 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bsS6X-0004dR-Rc for qemu-devel@nongnu.org; Fri, 07 Oct 2016 06:10:17 -0400 Received: from 11.mo6.mail-out.ovh.net ([188.165.38.119]:59153) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bsS6X-0004bp-KR for qemu-devel@nongnu.org; Fri, 07 Oct 2016 06:10:13 -0400 Received: from player738.ha.ovh.net (b7.ovh.net [213.186.33.57]) by mo6.mail-out.ovh.net (Postfix) with ESMTP id 84C2E35E9B for ; Fri, 7 Oct 2016 12:10:12 +0200 (CEST) Date: Fri, 7 Oct 2016 12:10:07 +0200 From: Greg Kurz Message-ID: <20161007121007.7d58b83e@bahia> In-Reply-To: References: <1475780218-26393-1-git-send-email-lvivier@redhat.com> <20161006224622.516cee20@bahia> <20161006235529.GI18490@umbus.fritz.box> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] qtest: ask endianness of the target in qtest_init() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell Cc: David Gibson , Laurent Vivier , QEMU Developers On Fri, 7 Oct 2016 10:39:09 +0100 Peter Maydell wrote: > On 7 October 2016 at 00:55, David Gibson wrote: > > It is an improvement. But I still think if we're relying on the > > ill-defined "target endianness" we're already doing something wrong. > > Target endianness is not ill-defined. It's a clear and constant > property of the bus the CPU is plugged into. It is a bit weird > to rely on it in the test code, which is why only the virtio > tests currently use qtest_big_endian(). > And to discourage anyone to use it in a test program, maybe it could even be renamed virtio_big_endian() and put in a virtio specific header file ? This is how it is done in QEMU. > thanks > -- PMM Cheers. -- Greg