From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:44413) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bsU7U-0000FG-Mk for qemu-devel@nongnu.org; Fri, 07 Oct 2016 08:19:21 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bsU7Q-0003QA-L8 for qemu-devel@nongnu.org; Fri, 07 Oct 2016 08:19:20 -0400 Received: from jessie.kos.to ([212.47.231.226]:49932 helo=pilvi.kos.to) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bsU7Q-0003Lv-Es for qemu-devel@nongnu.org; Fri, 07 Oct 2016 08:19:16 -0400 Date: Fri, 7 Oct 2016 12:19:08 +0000 From: Riku Voipio Message-ID: <20161007121908.GA28620@kos.to> References: <20160930233927.GA5887@nyan> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Subject: Re: [Qemu-devel] [PATCH] linux-user: use libc wrapper instead of direct mremap syscall List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell Cc: Felix Janda , QEMU Developers On Fri, Sep 30, 2016 at 07:35:45PM -0700, Peter Maydell wrote: > On 30 September 2016 at 16:39, Felix Janda wrote: > > This commit essentially reverts commit > > 3af72a4d98dca033492102603734cbc63cd2694a, which has replaced > > five-argument calls to mremap() by direct mremap syscalls for > > compatibility with glibc older than version 2.4. > > > > The direct syscall was buggy for 64bit targets on 32bit hosts > > because of the default integer type promotions. Since glibc-2.4 > > is now a decade old, we can remove this workaround. > > > > Signed-off-by: Felix Janda > > > Reviewed-by: Peter Maydell Applied to linux-user, thanks