From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:47739) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bsVuj-0005pu-QK for qemu-devel@nongnu.org; Fri, 07 Oct 2016 10:14:18 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bsVue-000627-T6 for qemu-devel@nongnu.org; Fri, 07 Oct 2016 10:14:16 -0400 Received: from mx1.redhat.com ([209.132.183.28]:60670) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bsVue-000614-MK for qemu-devel@nongnu.org; Fri, 07 Oct 2016 10:14:12 -0400 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 2FBF831B31C for ; Fri, 7 Oct 2016 14:14:12 +0000 (UTC) Date: Fri, 7 Oct 2016 15:14:09 +0100 From: "Daniel P. Berrange" Message-ID: <20161007141409.GD4619@redhat.com> Reply-To: "Daniel P. Berrange" References: <1475588159-30598-1-git-send-email-berrange@redhat.com> <1475848277-10183-1-git-send-email-berrange@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <1475848277-10183-1-git-send-email-berrange@redhat.com> Subject: Re: [Qemu-devel] [PATCH v6 21/20] linux-user/bsd-user: initialize trace events subsystem List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Stefan Hajnoczi Just Cc'ing Stefan this time On Fri, Oct 07, 2016 at 02:51:17PM +0100, Daniel P. Berrange wrote: > The bsd-user/linux-user programs make use of the CPU emulation > code and this now requires that the trace events subsystem > is enabled, otherwise it'll crash trying to allocate an empty > trace events bitmap for the CPU object. > > Signed-off-by: Daniel P. Berrange > --- > > Stefan, technically this patch ought to be squashed into: > > [PATCH v6 13/20] trace: provide mechanism for registering trace events > > bsd-user/main.c | 1 + > linux-user/main.c | 1 + > 2 files changed, 2 insertions(+) > > diff --git a/bsd-user/main.c b/bsd-user/main.c > index d803d3e..90d5bbd 100644 > --- a/bsd-user/main.c > +++ b/bsd-user/main.c > @@ -730,6 +730,7 @@ int main(int argc, char **argv) > if (argc <= 1) > usage(); > > + module_call_init(MODULE_INIT_TRACE); > qemu_init_cpu_list(); > module_call_init(MODULE_INIT_QOM); > > diff --git a/linux-user/main.c b/linux-user/main.c > index 9e4b430..0e31dad 100644 > --- a/linux-user/main.c > +++ b/linux-user/main.c > @@ -4158,6 +4158,7 @@ int main(int argc, char **argv, char **envp) > int ret; > int execfd; > > + module_call_init(MODULE_INIT_TRACE); > qemu_init_cpu_list(); > module_call_init(MODULE_INIT_QOM); > > -- > 2.7.4 > Regards, Daniel -- |: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :| |: http://libvirt.org -o- http://virt-manager.org :| |: http://entangle-photo.org -o- http://search.cpan.org/~danberr/ :|