From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:49991) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bsUtV-0003wW-HJ for qemu-devel@nongnu.org; Fri, 07 Oct 2016 09:08:58 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bsUtP-0003Jb-Hh for qemu-devel@nongnu.org; Fri, 07 Oct 2016 09:08:56 -0400 Received: from 8.mo6.mail-out.ovh.net ([178.33.42.204]:40621) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bsUtP-0003JB-9Z for qemu-devel@nongnu.org; Fri, 07 Oct 2016 09:08:51 -0400 Received: from player738.ha.ovh.net (b7.ovh.net [213.186.33.57]) by mo6.mail-out.ovh.net (Postfix) with ESMTP id 73009369BD for ; Fri, 7 Oct 2016 15:08:50 +0200 (CEST) Date: Fri, 7 Oct 2016 15:08:46 +0200 From: Greg Kurz Message-ID: <20161007150846.2041fab1@bahia> In-Reply-To: <09992696-731a-248b-bf59-ed95087c0256@redhat.com> References: <1475835267-7300-1-git-send-email-lvivier@redhat.com> <20161007124849.7c867d79@bahia> <20161007142738.73a94338@bahia> <20161007144542.118082e2@bahia> <09992696-731a-248b-bf59-ed95087c0256@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v2] qtest: ask endianness of the target in qtest_init() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Laurent Vivier Cc: Peter Maydell , QEMU Developers , David Gibson On Fri, 7 Oct 2016 14:56:26 +0200 Laurent Vivier wrote: > On 07/10/2016 14:52, Peter Maydell wrote: > > On 7 October 2016 at 13:45, Greg Kurz wrote: > >> On Fri, 7 Oct 2016 13:31:10 +0100 > >> Peter Maydell wrote: > >> > >>> On 7 October 2016 at 13:27, Greg Kurz wrote: > >>>> Indeed but my suggestion is to open code this in qvirtio_is_big_endian(), > >>>> and even rename QTestState::big_endian to virtio_big_endian to make it > >>>> really obvious it should not be used elsewhere. > >>>> > >>>> I now remember this is what I was resolutely suggested to do in > >>>> include/qom/cpu.h at the time we started to support ppc64le: > >>>> > >>>> bool (*virtio_is_big_endian)(CPUState *cpu); > >>> > >>> Not really the same thing though -- virtio_is_big_endian > >>> in QEMU is indeed used only in virtio, because it makes > >>> dubious use of the internals of the CPU state. The > >>> equivalent of this proposed qtest function is the #define > >>> TARGET_BIG_ENDIAN, which is global to all of QEMU and > >>> reasonably widely used (because it's not a property of > >>> the CPU's internals). > >>> > >> > >> Indeed but is it expected to be used in other tests than > >> virtio ? > > > > Well, that's where we came in. > > > > Personally I'd rather see this patch purely fix the current > > rather dodgy implementation of the existing qtest_big_endian() > > function, which seems to be non-controversial, rather than > > getting bogged down too much in the questions about what the > > function name should be and how widely it should be used, etc. > > I'd rather too.. > Fair enough. > And I can rework this part later, as I've a series to enable virtio > tests for SPAPR. > > So if v2 covers all non virtio naming space issues, is it acceptable as-is? > What I said with v1 still stands: this is an improvement over what we currently have. Reviewed-by: Greg Kurz > Thanks, > Laurent Cheers. -- Greg