From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:56629) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1btPSc-0002Ct-Sr for qemu-devel@nongnu.org; Sun, 09 Oct 2016 21:32:59 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1btPSY-00045M-LG for qemu-devel@nongnu.org; Sun, 09 Oct 2016 21:32:57 -0400 Received: from ozlabs.org ([103.22.144.67]:49771) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1btPSY-00042x-48 for qemu-devel@nongnu.org; Sun, 09 Oct 2016 21:32:54 -0400 Date: Mon, 10 Oct 2016 12:28:26 +1100 From: David Gibson Message-ID: <20161010012826.GD18309@umbus.fritz.box> References: <1475780218-26393-1-git-send-email-lvivier@redhat.com> <20161006224622.516cee20@bahia> <20161006235529.GI18490@umbus.fritz.box> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="eqp4TxRxnD4KrmFZ" Content-Disposition: inline In-Reply-To: Subject: Re: [Qemu-devel] [PATCH] qtest: ask endianness of the target in qtest_init() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell Cc: Greg Kurz , Laurent Vivier , QEMU Developers --eqp4TxRxnD4KrmFZ Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Oct 07, 2016 at 10:39:09AM +0100, Peter Maydell wrote: > On 7 October 2016 at 00:55, David Gibson wr= ote: > > It is an improvement. But I still think if we're relying on the > > ill-defined "target endianness" we're already doing something wrong. >=20 > Target endianness is not ill-defined. It's a clear and constant > property of the bus the CPU is plugged into. It's certainly not clear to me. How are you defining it? Preferably in terms of visible effects, rather than something that requires snooping into pieces of hardware that aren't actually modelled in qemu... > It is a bit weird > to rely on it in the test code, which is why only the virtio > tests currently use qtest_big_endian(). >=20 > thanks > -- PMM >=20 --=20 David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson --eqp4TxRxnD4KrmFZ Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBCAAGBQJX+u64AAoJEGw4ysog2bOShC8P/3H1NuwUOwbfnbXLicUKPf2X Hh6aK5HuV5F72MgrVTpKl180d2TGePG10SJpGoso+Frc7zgquNOa7oPFyK0ctAKm tk3aNqElTSvABswXmfkXGd+kaVYpUw2iu4ZQesfM2fCmjNS/IriTa0NUn7VlMzQ8 iAC2uSpYE5UgxYj4M2Z8ZvCc7u96TxUCA/6ALGqnHjwMhPrTuN5PMeWLe6UxZFXS 7o5EIH9tNR3ktCiWlwkq2wGKximn3eUr+HcgoVimj2vLnY3d+hAokIgRuwseQwp/ RXhdP5L9Bw3Q8KWdkLRECBfY98oEG6fNVaAEQEibUll72rc7dsGLDC+dXoLmczKO 2oKMqw7884C3S52+5Lr3eTUV+izBeY6NIuDscoYOzVpw3uX7p+pXGufAVVAR6QYc qcoK6HFOrSK0WZZfDFRmGmbT0o54D3IlYzIbTb7+SxV/iISj0sXs10WEKlVSVlTp ej5MiSdNUEOFIHRSAzexifw3IF8uYo6pizrbEDEOBFknH1VqNnxNGja6ErHL4yTT 1rWaplkNpCdM2wtoGF/+gZb00etPDpVnBwVyqmP1vYk8VE6ZwfM8CZ1sPkxUqiw9 6dNNLxgshUq4GCYsU4ZwbvXialzt1h6DRFHTqnr0Cq9zYyhzrYwFZMDQurftAAdE nSsVgBbMi4BBMcL8tUXM =oAJf -----END PGP SIGNATURE----- --eqp4TxRxnD4KrmFZ--