From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:56628) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1btPSc-0002Cu-Sv for qemu-devel@nongnu.org; Sun, 09 Oct 2016 21:33:00 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1btPSY-00045H-L2 for qemu-devel@nongnu.org; Sun, 09 Oct 2016 21:32:57 -0400 Received: from ozlabs.org ([103.22.144.67]:49761) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1btPSY-00042w-78 for qemu-devel@nongnu.org; Sun, 09 Oct 2016 21:32:54 -0400 Date: Mon, 10 Oct 2016 12:30:57 +1100 From: David Gibson Message-ID: <20161010013057.GE18309@umbus.fritz.box> References: <1475780218-26393-1-git-send-email-lvivier@redhat.com> <20161006224622.516cee20@bahia> <20161006235529.GI18490@umbus.fritz.box> <20161007121007.7d58b83e@bahia> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="N1GIdlSm9i+YlY4t" Content-Disposition: inline In-Reply-To: <20161007121007.7d58b83e@bahia> Subject: Re: [Qemu-devel] [PATCH] qtest: ask endianness of the target in qtest_init() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Greg Kurz Cc: Peter Maydell , Laurent Vivier , QEMU Developers --N1GIdlSm9i+YlY4t Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Oct 07, 2016 at 12:10:07PM +0200, Greg Kurz wrote: > On Fri, 7 Oct 2016 10:39:09 +0100 > Peter Maydell wrote: >=20 > > On 7 October 2016 at 00:55, David Gibson = wrote: > > > It is an improvement. But I still think if we're relying on the > > > ill-defined "target endianness" we're already doing something wrong. = =20 > >=20 > > Target endianness is not ill-defined. It's a clear and constant > > property of the bus the CPU is plugged into. It is a bit weird > > to rely on it in the test code, which is why only the virtio > > tests currently use qtest_big_endian(). > >=20 >=20 > And to discourage anyone to use it in a test program, maybe it > could even be renamed virtio_big_endian() and put in a virtio > specific header file ? This is how it is done in QEMU. I think that's a good idea. --=20 David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson --N1GIdlSm9i+YlY4t Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIbBAEBCAAGBQJX+u9RAAoJEGw4ysog2bOSTk8P+OfrSvvMi0PcCPlbkFKadTQB s7LiengWTh8cmR+T2GBg0Ldq3XM15APnUVwhCWUIXNnoNDalN3hV3AAvVoqfVdc3 89QQcga7/JVHzrZuV77ClpGbHrplRJT3jUVEnpbEQKd2/MDaf3PHEzSCHqpUewMp Dv2hQPa6rAUsBXeKa4s4DUjrOPL/hHZBWe3wTEWTg7r3H0eSv+bnmIDF/G7aG7q6 w2BCYbYEcQ7RAvfeYhe+fnEW5rDeOjM+x4ByZHyy+QtwI3eg71nnmQYVyw0YNrZb 3F/cm9Byn0XW7Uj9imzf3xQ76KanXa3B0wQTgf7c8UNGIxGLn2scvjKKXne0K9LU UHUUvzmtso+tA/B9w4pkMBC/l91nk4/IOiju2IUS8ZhXmt2Y5w1lgpGOZ64X8h8m JNFfiw9nuC2j1WYeWlfgyWiMQWn8XLfIb0BIpYexhm8UFXbywJ3KUVTGjSid1NDl WG+/lvULbgpjAlKdj17U++9O+8dOtuKiOC5rkRDFvxBFFFvV8ya7R/5e+xnxT5Am 431wvQXhhPFYO7kVEZIK1uMbVO/qXkL6WTP+nno9nG7ELp9TktwOlA3qz0zD1BqW XV9mLffNEgYWo+5GAsV+Ak+nSQGWyLeJpGOFptcsnn8XH5QBGAGc1glUI2152LKa 9KQL01iYynGcdcfm5qc= =fpdh -----END PGP SIGNATURE----- --N1GIdlSm9i+YlY4t--