From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:54822) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1btYdh-0000eC-LI for qemu-devel@nongnu.org; Mon, 10 Oct 2016 07:21:02 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1btYdb-0008Ic-C2 for qemu-devel@nongnu.org; Mon, 10 Oct 2016 07:21:00 -0400 Received: from 10.mo6.mail-out.ovh.net ([87.98.157.236]:40986) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1btYdb-0008IU-5p for qemu-devel@nongnu.org; Mon, 10 Oct 2016 07:20:55 -0400 Received: from player738.ha.ovh.net (b7.ovh.net [213.186.33.57]) by mo6.mail-out.ovh.net (Postfix) with ESMTP id 7D4B528175 for ; Mon, 10 Oct 2016 13:20:54 +0200 (CEST) Date: Mon, 10 Oct 2016 13:20:51 +0200 From: Greg Kurz Message-ID: <20161010132051.7e1b3623@bahia> In-Reply-To: <57fb706a.a8c8c20a.2886d.5bd5@mx.google.com> References: <57fb706a.a8c8c20a.2886d.5bd5@mx.google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] 9pfs: fix memory leak in v9fs_xattrcreate List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Li Qiang Cc: qemu-devel@nongnu.org, Li Qiang On Mon, 10 Oct 2016 03:41:38 -0700 Li Qiang wrote: > From: Li Qiang > > The 'fs.xattr.value' field in V9fsFidState object doesn't consider the > situation that this field has been allocated previously. Every time, it > will be allocated directly. This leads a host memory leak issue. This > patch fix this. > > Signed-off-by: Li Qiang > --- I'll add to the changelog that this may happen if the client sends a Txattrcreate message with the same fid number before the fid was clunked. Reviewed-by: Greg Kurz > hw/9pfs/9p.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/hw/9pfs/9p.c b/hw/9pfs/9p.c > index 8751c19..e4040dc 100644 > --- a/hw/9pfs/9p.c > +++ b/hw/9pfs/9p.c > @@ -3282,6 +3282,7 @@ static void v9fs_xattrcreate(void *opaque) > xattr_fidp->fs.xattr.flags = flags; > v9fs_string_init(&xattr_fidp->fs.xattr.name); > v9fs_string_copy(&xattr_fidp->fs.xattr.name, &name); > + g_free(xattr_fidp->fs.xattr.value); > xattr_fidp->fs.xattr.value = g_malloc0(size); > err = offset; > put_fid(pdu, file_fidp);