From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:52674)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <peterx@redhat.com>) id 1btkNw-0008Qd-Sy
	for qemu-devel@nongnu.org; Mon, 10 Oct 2016 19:53:33 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <peterx@redhat.com>) id 1btkNs-00022I-0z
	for qemu-devel@nongnu.org; Mon, 10 Oct 2016 19:53:32 -0400
Received: from mx1.redhat.com ([209.132.183.28]:36516)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <peterx@redhat.com>) id 1btkNr-00021t-Qi
	for qemu-devel@nongnu.org; Mon, 10 Oct 2016 19:53:27 -0400
Date: Tue, 11 Oct 2016 07:53:23 +0800
From: Peter Xu <peterx@redhat.com>
Message-ID: <20161010235323.GE30787@pxdev.xzpeter.org>
References: <20161005130657.3399-1-rkrcmar@redhat.com>
	<20161005130657.3399-7-rkrcmar@redhat.com>
	<20161008072100.GJ3666@pxdev.xzpeter.org>
	<20161010151119.GB30525@potion>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <20161010151119.GB30525@potion>
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH v4 6/8] intel_iommu: reject broken EIM
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel/>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Radim =?utf-8?B?S3LEjW3DocWZ?= <rkrcmar@redhat.com>
Cc: qemu-devel@nongnu.org, Igor Mammedov <imammedo@redhat.com>, Paolo Bonzini <pbonzini@redhat.com>, Richard Henderson <rth@twiddle.net>, Eduardo Habkost <ehabkost@redhat.com>, "Michael S. Tsirkin" <mst@redhat.com>

On Mon, Oct 10, 2016 at 05:11:19PM +0200, Radim Kr=C4=8Dm=C3=A1=C5=99 wro=
te:

[...]

> > But that's really a matter of taste. So:
>=20
> I'll currently go for an implicit else: (because 4 levels of indentatio=
n
> are getting helper-function worthy and it has less curly braces)
>=20
>         if (!kvm_irqchip_in_kernel()) {
>             error("need split irqchip");
>             return false;
>         }
>         if (!kvm_enable_x2apic()) {
>             error("enable x2apic failed");
>             return false;
>         }

Good to me.

>=20
> > Reviewed-by: Peter Xu <peterx@redhat.com>
>=20
> I squashed [7/8] into this patch in v5 and the second one didn't have
> your r-b, so I made the change as I'd have to drop the r-b anyway.

Sure. Thanks,

-- peterx