From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:44051)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <famz@redhat.com>) id 1bttn3-0003Nz-MC
	for qemu-devel@nongnu.org; Tue, 11 Oct 2016 05:56:09 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <famz@redhat.com>) id 1bttmz-00015F-NO
	for qemu-devel@nongnu.org; Tue, 11 Oct 2016 05:56:05 -0400
Received: from mx1.redhat.com ([209.132.183.28]:63758)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <famz@redhat.com>) id 1bttmz-00014l-HG
	for qemu-devel@nongnu.org; Tue, 11 Oct 2016 05:56:01 -0400
Date: Tue, 11 Oct 2016 17:55:58 +0800
From: Fam Zheng <famz@redhat.com>
Message-ID: <20161011095558.GE5814@lemon>
References: <20161003163212.8101-1-alex.bennee@linaro.org>
	<20161003163212.8101-3-alex.bennee@linaro.org>
	<20161011083137.GC5814@lemon> <8760ozxoax.fsf@linaro.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
In-Reply-To: <8760ozxoax.fsf@linaro.org>
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH v2 2/4] tests/docker: test-build script
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel/>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Alex =?iso-8859-1?Q?Benn=E9e?= <alex.bennee@linaro.org>
Cc: qemu-devel@nongnu.org

On Tue, 10/11 09:49, Alex Benn=E9e wrote:
>=20
> Fam Zheng <famz@redhat.com> writes:
>=20
> > On Mon, 10/03 17:32, Alex Benn=E9e wrote:
> >> Much like test-quick but only builds. This is useful for some of the
> >> build targets like ThreadSanitizer that don't yet pass "make check".
> >>
> >> Signed-off-by: Alex Benn=E9e <alex.bennee@linaro.org>
> >> ---
> >>  tests/docker/test-build | 18 ++++++++++++++++++
> >>  1 file changed, 18 insertions(+)
> >>  create mode 100755 tests/docker/test-build
> >>
> >> diff --git a/tests/docker/test-build b/tests/docker/test-build
> >> new file mode 100755
> >> index 0000000..d237ead
> >> --- /dev/null
> >> +++ b/tests/docker/test-build
> >> @@ -0,0 +1,18 @@
> >> +#!/bin/bash -e
> >> +#
> >> +# Quick compiling test that everyone already does. But why not auto=
mate it?
> >> +#
> >> +# Copyright (c) 2016 Red Hat Inc.
> >> +#
> >> +# Authors:
> >> +#  Fam Zheng <famz@redhat.com>
> >> +#
> >> +# This work is licensed under the terms of the GNU GPL, version 2
> >> +# or (at your option) any later version. See the COPYING file in
> >> +# the top-level directory.
> >> +
> >> +. common.rc
> >> +
> >> +DEF_TARGET_LIST=3D"$(echo {x86_64,aarch64}-softmmu)"
> >
> > Like I said in v1, better flatten this to "x86_64-softmmu,aarch64-sof=
tmmu" as it
> > is in test-quick now.
>=20
> oops, sorry missed that. Will fix.

While we are at it, how about copying from test-full to cover more target=
s?

Fam

>=20
> >
> > Fam
> >
> >> +TARGET_LIST=3D${TARGET_LIST:-$DEF_TARGET_LIST} \
> >> +build_qemu
> >> --
> >> 2.9.3
> >>
>=20
>=20
> --
> Alex Benn=E9e