From: "Daniel P. Berrange" <berrange@redhat.com>
To: Eduardo Habkost <ehabkost@redhat.com>
Cc: qemu-devel@nongnu.org, "Markus Armbruster" <armbru@redhat.com>,
"Andreas Färber" <afaerber@suse.de>
Subject: Re: [Qemu-devel] [PATCH 1/2] tests: check-qom-proplist: Remove "bv" class property from class
Date: Tue, 11 Oct 2016 13:39:48 +0100 [thread overview]
Message-ID: <20161011123948.GC14917@redhat.com> (raw)
In-Reply-To: <1476189467-11804-2-git-send-email-ehabkost@redhat.com>
On Tue, Oct 11, 2016 at 09:37:46AM -0300, Eduardo Habkost wrote:
> The object_property_add_bool() call in dummy_init() was always
> failing because there was a "bv" class property already. Remove
> the class property so both object properties and class properties
> are covered by the test code.
>
> Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
> ---
> tests/check-qom-proplist.c | 4 ----
> 1 file changed, 4 deletions(-)
Reviewed-by: Daniel P. Berrange <berrange@redhat.com>
Regards,
Daniel
--
|: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org -o- http://virt-manager.org :|
|: http://entangle-photo.org -o- http://search.cpan.org/~danberr/ :|
next prev parent reply other threads:[~2016-10-11 12:39 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-11 12:37 [Qemu-devel] [PATCH 0/2] tests: A few check-qom-proplist fixes Eduardo Habkost
2016-10-11 12:37 ` [Qemu-devel] [PATCH 1/2] tests: check-qom-proplist: Remove "bv" class property from class Eduardo Habkost
2016-10-11 12:39 ` Daniel P. Berrange [this message]
2016-10-11 12:37 ` [Qemu-devel] [PATCH 2/2] tests: check-qom-proplist: Use &error_abort to catch errors Eduardo Habkost
2016-10-11 12:40 ` Daniel P. Berrange
2016-10-17 21:02 ` [Qemu-devel] [PATCH 0/2] tests: A few check-qom-proplist fixes Eduardo Habkost
2016-10-17 22:07 ` Andreas Färber
2016-10-18 13:58 ` Eduardo Habkost
2016-10-25 18:40 ` Eduardo Habkost
2016-11-03 16:51 ` Markus Armbruster
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161011123948.GC14917@redhat.com \
--to=berrange@redhat.com \
--cc=afaerber@suse.de \
--cc=armbru@redhat.com \
--cc=ehabkost@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).