qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
* [Qemu-devel] Potential Bug in vIOMMU which may result in memory wasting
@ 2016-10-12  5:02 Liu, Yi L
  2016-10-12  7:02 ` no-reply
  0 siblings, 1 reply; 7+ messages in thread
From: Liu, Yi L @ 2016-10-12  5:02 UTC (permalink / raw)
  To: qemu-devel@nongnu.org; +Cc: Ji, John, Wu, Feng

Hi,

Resend it here since there is code style issue with debug patch in
previous email.

1. Problem description:
Recently, I find a strange thing with vIOMMU in QEMU. It looks like
g_hash_table_lookup() is not 100% give same result when the key
is the same. And this results in redundant memory allocation.
I'm not sure if it is expected. Has anyone else encountered it? 

This potential issue is in vtd_find_add_as(), it uses the input PCIBus
pointer to lookup hash table and get a vtd_bus back. If no hit,
allocate one and inset it to hash_table. In my understanding, a pci
bus only requires a single vtd_bus structure. But what I observed
denied it.

2. Command to start guest:
x86_64-softmmu/qemu-system-x86_64 -boot c
-hda /home/sky/vms/vm-for-svm/svm-disk.img
-m 5120 -enable-kvm -machine type=q35 -device intel-iommu
-net nic -net tap,ifname=tap0, script=no,downscript=no -device
vfio-pci,host=00:02.0,id=hostdev0,addr=0x6

3. Log:
a) First enter of vtd_find_add_as(), no corresponding vtd_bus in
s->vtd_as_by_busptr, so allocate one, this is quite reasonable.
------------------------------
YiLiu - vtd_find_add_as()
 bus: 0x5606747f99c0
 s: 0x560675a2e000
 s->vtd_as_by_busptr: 0x560675c521e0, devfn: 0x0
 lookup result: no vtd_bus, allocate one
 vtd_bus: 0x56067457a620
  vtd_bus in s->vtd_as_by_busptr: 0x56067457a620
    lookup hash_table again, vtd_bus: 0x56067457a620

b) Second enter of vtd_find_add_as(), again no corresponding
vtd_bus in s->vtd_as_by_busptr, so allocate one, this is strange
since devfn: 0x30 is actually also under pci bus 0.
------------------------------
YiLiu - vtd_find_add_as()
 bus: 0x5606747f99c0
 s: 0x560675a2e000
 s->vtd_as_by_busptr: 0x560675c521e0, devfn: 0x30
 lookup result: no vtd_bus, allocate one
 vtd_bus: 0x56067598fef0
  vtd_bus in s->vtd_as_by_busptr: 0x56067457a620
  vtd_bus in s->vtd_as_by_busptr: 0x56067598fef0
    lookup hash_table again, vtd_bus: 0x56067598fef0

c) Third enter of vtd_find_add_as(),no corresponding vtd_bus
in s->vtd_as_by_busptr, so allocate one, this also strange since
there should have a vtd_bus in hash table for pci bus 0.
------------------------------
YiLiu - vtd_find_add_as()
 bus: 0x5606747f99c0
 s: 0x560675a2e000
 s->vtd_as_by_busptr: 0x560675c521e0, devfn: 0x0
 lookup result: no vtd_bus, allocate one
 vtd_bus: 0x5606746aa400
  vtd_bus in s->vtd_as_by_busptr: 0x5606746aa400
  vtd_bus in s->vtd_as_by_busptr: 0x56067457a620
  vtd_bus in s->vtd_as_by_busptr: 0x56067598fef0
    lookup hash_table again, vtd_bus: 0x5606746aa400

d) reset seems to be correct, however, there is totally 3 vtd_bus
structure for pci bus 0. this is a waste of memory in my
understanding.
------------------------------
YiLiu - vtd_find_add_as()
 bus: 0x5606747f99c0
 s: 0x560675a2e000
 s->vtd_as_by_busptr: 0x560675c521e0, devfn: 0x8
 lookup result: got vtd_bus
 vtd_bus: 0x5606746aa400
  vtd_bus in s->vtd_as_by_busptr: 0x5606746aa400
  vtd_bus in s->vtd_as_by_busptr: 0x56067457a620
  vtd_bus in s->vtd_as_by_busptr: 0x56067598fef0
    lookup hash_table again, vtd_bus: 0x5606746aa400
------------------------------
YiLiu - vtd_find_add_as()
 bus: 0x5606747f99c0
 s: 0x560675a2e000
 s->vtd_as_by_busptr: 0x560675c521e0, devfn: 0x10
 lookup result: got vtd_bus
 vtd_bus: 0x5606746aa400
  vtd_bus in s->vtd_as_by_busptr: 0x5606746aa400
  vtd_bus in s->vtd_as_by_busptr: 0x56067457a620
  vtd_bus in s->vtd_as_by_busptr: 0x56067598fef0
    lookup hash_table again, vtd_bus: 0x5606746aa400
------------------------------
YiLiu - vtd_find_add_as()
 bus: 0x5606747f99c0
 s: 0x560675a2e000
 s->vtd_as_by_busptr: 0x560675c521e0, devfn: 0x30
 lookup result: got vtd_bus
 vtd_bus: 0x5606746aa400
  vtd_bus in s->vtd_as_by_busptr: 0x5606746aa400
  vtd_bus in s->vtd_as_by_busptr: 0x56067457a620
  vtd_bus in s->vtd_as_by_busptr: 0x56067598fef0
    lookup hash_table again, vtd_bus: 0x5606746aa400
------------------------------
YiLiu - vtd_find_add_as()
 bus: 0x5606747f99c0
 s: 0x560675a2e000
 s->vtd_as_by_busptr: 0x560675c521e0, devfn: 0xf8
 lookup result: got vtd_bus
 vtd_bus: 0x5606746aa400
  vtd_bus in s->vtd_as_by_busptr: 0x5606746aa400
  vtd_bus in s->vtd_as_by_busptr: 0x56067457a620
  vtd_bus in s->vtd_as_by_busptr: 0x56067598fef0
    lookup hash_table again, vtd_bus: 0x5606746aa400
------------------------------
YiLiu - vtd_find_add_as()
 bus: 0x5606747f99c0
 s: 0x560675a2e000
 s->vtd_as_by_busptr: 0x560675c521e0, devfn: 0xfa
 lookup result: got vtd_bus
 vtd_bus: 0x5606746aa400
  vtd_bus in s->vtd_as_by_busptr: 0x5606746aa400
  vtd_bus in s->vtd_as_by_busptr: 0x56067457a620
  vtd_bus in s->vtd_as_by_busptr: 0x56067598fef0
    lookup hash_table again, vtd_bus: 0x5606746aa400
------------------------------
YiLiu - vtd_find_add_as()
 bus: 0x5606747f99c0
 s: 0x560675a2e000
 s->vtd_as_by_busptr: 0x560675c521e0, devfn: 0xfb
 lookup result: got vtd_bus
 vtd_bus: 0x5606746aa400
  vtd_bus in s->vtd_as_by_busptr: 0x5606746aa400
  vtd_bus in s->vtd_as_by_busptr: 0x56067457a620
  vtd_bus in s->vtd_as_by_busptr: 0x56067598fef0
    lookup hash_table again, vtd_bus: 0x5606746aa400


4. QEMU version:
commit 48f592118ab42f83a1a7561c4bfd2b72a100f241
Author: Ed Maste <emaste@freebsd.org>
Date:   Tue Oct 4 16:02:49 2016 -0400

    bsd-user: fix FreeBSD build after d148d90e

    Signed-off-by: Ed Maste <emaste@freebsd.org>
    Message-id: 1475611369-74971-1-git-send-email-emaste@freebsd.org
    Signed-off-by: Peter Maydell <peter.maydell@linaro.org>


5. Debug code:
>From d45c1ae01c0b6b953c95d9af1b6ffce64a6e2382 Mon Sep 17 00:00:00 2001
From: Yi Liu <yi.l.liu@intel.com>
Date: Wed, 12 Oct 2016 12:26:45 +0800
Subject: [PATCH 1/2] enable vIOMMU work together with VFIO

Signed-off-by: Yi Liu <yi.l.liu@intel.com>
---
 hw/i386/intel_iommu.c | 2 ++
 hw/pci/pcie.c         | 2 +-
 hw/vfio/common.c      | 2 +-
 3 files changed, 4 insertions(+), 2 deletions(-)

diff --git a/hw/i386/intel_iommu.c b/hw/i386/intel_iommu.c
index 9f4e64a..d76985e 100644
--- a/hw/i386/intel_iommu.c
+++ b/hw/i386/intel_iommu.c
@@ -1978,6 +1978,7 @@ static void vtd_iommu_notify_flag_changed(MemoryRegion *iommu,
                                           IOMMUNotifierFlag old,
                                           IOMMUNotifierFlag new)
 {
+/*
     VTDAddressSpace *vtd_as = container_of(iommu, VTDAddressSpace, iommu);

     if (new & IOMMU_NOTIFIER_MAP) {
@@ -1988,6 +1989,7 @@ static void vtd_iommu_notify_flag_changed(MemoryRegion *iommu,
                      PCI_FUNC(vtd_as->devfn));
         exit(1);
     }
+*/
 }

 static const VMStateDescription vtd_vmstate = {
diff --git a/hw/pci/pcie.c b/hw/pci/pcie.c
index 99cfb45..0355ffd 100644
--- a/hw/pci/pcie.c
+++ b/hw/pci/pcie.c
@@ -683,7 +683,7 @@ void pcie_add_capability(PCIDevice *dev,
            in the linked list */
         next = pcie_find_capability_list(dev, 0, &prev);

-        assert(prev >= PCI_CONFIG_SPACE_SIZE);
+        /*assert(prev >= PCI_CONFIG_SPACE_SIZE);*/
         assert(next == 0);
         pcie_ext_cap_set_next(dev, prev, offset);
     }
diff --git a/hw/vfio/common.c b/hw/vfio/common.c
index 29188a1..242a5b1 100644
--- a/hw/vfio/common.c
+++ b/hw/vfio/common.c
@@ -457,7 +457,7 @@ static void vfio_listener_region_add(MemoryListener *listener,
         QLIST_INSERT_HEAD(&container->giommu_list, giommu, giommu_next);

         memory_region_register_iommu_notifier(giommu->iommu, &giommu->n);
-        memory_region_iommu_replay(giommu->iommu, &giommu->n, false);
+        /*memory_region_iommu_replay(giommu->iommu, &giommu->n, false);*/

         return;
     }
--
1.9.1

>From c193868dcb1179637d0aa646500a17daf91e8429 Mon Sep 17 00:00:00 2001
From: Yi Liu <yi.l.liu@intel.com>
Date: Wed, 12 Oct 2016 12:29:18 +0800
Subject: [PATCH 2/2] debug code for potential issue in vtd_find_add_as()

Signed-off-by: Yi Liu <yi.l.liu@intel.com>
---
 hw/i386/intel_iommu.c | 34 ++++++++++++++++++++++++++++++++++
 1 file changed, 34 insertions(+)

diff --git a/hw/i386/intel_iommu.c b/hw/i386/intel_iommu.c
index d76985e..04b62b2 100644
--- a/hw/i386/intel_iommu.c
+++ b/hw/i386/intel_iommu.c
@@ -2312,14 +2312,31 @@ VTDAddressSpace *vtd_find_add_as(IntelIOMMUState *s, PCIBus *bus, int devfn)
     VTDBus *vtd_bus = g_hash_table_lookup(s->vtd_as_by_busptr, &key);
     VTDAddressSpace *vtd_dev_as;

+    /* Yi: add for debug */
+    printf("------------------------------\n"
+           "YiLiu - %s()\n"
+           " bus: 0x%llx\n"
+           " s: 0x%llx\n"
+           " s->vtd_as_by_busptr: 0x%llx,"
+           " devfn: 0x%x\n",
+           __func__,
+           (unsigned long long int) bus,
+           (unsigned long long int) s,
+           (unsigned long long int) s->vtd_as_by_busptr,
+           (unsigned int) devfn);
+
     if (!vtd_bus) {
+        printf(" lookup result: no vtd_bus, allocate one\n");
         /* No corresponding free() */
         vtd_bus = g_malloc0(sizeof(VTDBus) + sizeof(VTDAddressSpace *) * \
                             X86_IOMMU_PCI_DEVFN_MAX);
         vtd_bus->bus = bus;
         key = (uintptr_t)bus;
         g_hash_table_insert(s->vtd_as_by_busptr, &key, vtd_bus);
+    } else {
+        printf(" lookup result: got vtd_bus\n");
     }
+    printf(" vtd_bus: 0x%llx\n", (unsigned long long int) vtd_bus);

     vtd_dev_as = vtd_bus->dev_as[devfn];

@@ -2340,6 +2357,23 @@ VTDAddressSpace *vtd_find_add_as(IntelIOMMUState *s, PCIBus *bus, int devfn)
         address_space_init(&vtd_dev_as->as,
                            &vtd_dev_as->iommu, "intel_iommu");
     }
+
+    {/* Yi: code snippet for debug, dump the vtd_as_by_busptr
+        to see if all the allocated vtd_bus are still there */
+        GHashTableIter iter;
+        g_hash_table_iter_init(&iter, s->vtd_as_by_busptr);
+        while (g_hash_table_iter_next(&iter, NULL, (void **)&vtd_bus)) {
+            if (pci_bus_num(vtd_bus->bus) == pci_bus_num(bus)) {
+                printf("  vtd_bus in s->vtd_as_by_busptr: 0x%llx\n",
+                                        (unsigned long long int) vtd_bus);
+            }
+        }
+        /* look up hash table again */
+        vtd_bus = g_hash_table_lookup(s->vtd_as_by_busptr, &key);
+        printf("    lookup hash_table again, vtd_bus: 0x%llx\n",
+                                  (unsigned long long int) vtd_bus);
+    }
+
     return vtd_dev_as;
 }

--
1.9.1


Best Wishes,
Yi Liu

^ permalink raw reply related	[flat|nested] 7+ messages in thread
* [Qemu-devel] Potential Bug in vIOMMU which may result in memory wasting
@ 2016-10-11  9:16 Liu, Yi L
  2016-10-11 21:40 ` no-reply
  2016-10-12  0:56 ` no-reply
  0 siblings, 2 replies; 7+ messages in thread
From: Liu, Yi L @ 2016-10-11  9:16 UTC (permalink / raw)
  To: qemu-devel@nongnu.org; +Cc: Ji, John, Wu, Feng

Hi,

Apologize for failing to make this email in short. Log is too long.
If the following statements failed to make me understood, you
are welcomed to ping me.

1. Problem description:
Recently, I find a strange thing with vIOMMU in QEMU. It looks like
g_hash_table_lookup() is not 100% give same result when the key
is the same. And this results in redundant memory allocation.
I'm not sure if it is expected. Has anyone else encountered it? 

This potential issue is in vtd_find_add_as(), it uses the input PCIBus
pointer to lookup hash table and get a vtd_bus back. If no hit,
allocate one and inset it to hash_table. In my understanding, a pci
bus only requires a single vtd_bus structure. But what I observed
denied it.

2. Command to start guest:
x86_64-softmmu/qemu-system-x86_64 -boot c
-hda /home/sky/vms/vm-for-svm/svm-disk.img
-m 5120 -enable-kvm -machine type=q35 -device intel-iommu
-net nic -net tap,ifname=tap0, script=no,downscript=no -device
vfio-pci,host=00:02.0,id=hostdev0,addr=0x6

3. Log:
a) First enter of vtd_find_add_as(), no corresponding vtd_bus in
s->vtd_as_by_busptr, so allocate one, this is quite reasonable.
------------------------------
YiLiu - vtd_find_add_as()
 bus: 0x5606747f99c0
 s: 0x560675a2e000
 s->vtd_as_by_busptr: 0x560675c521e0, devfn: 0x0
 lookup result: no vtd_bus, allocate one
 vtd_bus: 0x56067457a620
  vtd_bus in s->vtd_as_by_busptr: 0x56067457a620
    lookup hash_table again, vtd_bus: 0x56067457a620

b) Second enter of vtd_find_add_as(), again no corresponding
vtd_bus in s->vtd_as_by_busptr, so allocate one, this is strange
since devfn: 0x30 is actually also under pci bus 0.
------------------------------
YiLiu - vtd_find_add_as()
 bus: 0x5606747f99c0
 s: 0x560675a2e000
 s->vtd_as_by_busptr: 0x560675c521e0, devfn: 0x30
 lookup result: no vtd_bus, allocate one
 vtd_bus: 0x56067598fef0
  vtd_bus in s->vtd_as_by_busptr: 0x56067457a620
  vtd_bus in s->vtd_as_by_busptr: 0x56067598fef0
    lookup hash_table again, vtd_bus: 0x56067598fef0

c) Third enter of vtd_find_add_as(),no corresponding vtd_bus
in s->vtd_as_by_busptr, so allocate one, this also strange since
there should have a vtd_bus in hash table for pci bus 0.
------------------------------
YiLiu - vtd_find_add_as()
 bus: 0x5606747f99c0
 s: 0x560675a2e000
 s->vtd_as_by_busptr: 0x560675c521e0, devfn: 0x0
 lookup result: no vtd_bus, allocate one
 vtd_bus: 0x5606746aa400
  vtd_bus in s->vtd_as_by_busptr: 0x5606746aa400
  vtd_bus in s->vtd_as_by_busptr: 0x56067457a620
  vtd_bus in s->vtd_as_by_busptr: 0x56067598fef0
    lookup hash_table again, vtd_bus: 0x5606746aa400

d) reset seems to be correct, however, there is totally 3 vtd_bus
structure for pci bus 0. this is a waste of memory in my
understanding.
------------------------------
YiLiu - vtd_find_add_as()
 bus: 0x5606747f99c0
 s: 0x560675a2e000
 s->vtd_as_by_busptr: 0x560675c521e0, devfn: 0x8
 lookup result: got vtd_bus
 vtd_bus: 0x5606746aa400
  vtd_bus in s->vtd_as_by_busptr: 0x5606746aa400
  vtd_bus in s->vtd_as_by_busptr: 0x56067457a620
  vtd_bus in s->vtd_as_by_busptr: 0x56067598fef0
    lookup hash_table again, vtd_bus: 0x5606746aa400
------------------------------
YiLiu - vtd_find_add_as()
 bus: 0x5606747f99c0
 s: 0x560675a2e000
 s->vtd_as_by_busptr: 0x560675c521e0, devfn: 0x10
 lookup result: got vtd_bus
 vtd_bus: 0x5606746aa400
  vtd_bus in s->vtd_as_by_busptr: 0x5606746aa400
  vtd_bus in s->vtd_as_by_busptr: 0x56067457a620
  vtd_bus in s->vtd_as_by_busptr: 0x56067598fef0
    lookup hash_table again, vtd_bus: 0x5606746aa400
------------------------------
YiLiu - vtd_find_add_as()
 bus: 0x5606747f99c0
 s: 0x560675a2e000
 s->vtd_as_by_busptr: 0x560675c521e0, devfn: 0x30
 lookup result: got vtd_bus
 vtd_bus: 0x5606746aa400
  vtd_bus in s->vtd_as_by_busptr: 0x5606746aa400
  vtd_bus in s->vtd_as_by_busptr: 0x56067457a620
  vtd_bus in s->vtd_as_by_busptr: 0x56067598fef0
    lookup hash_table again, vtd_bus: 0x5606746aa400
------------------------------
YiLiu - vtd_find_add_as()
 bus: 0x5606747f99c0
 s: 0x560675a2e000
 s->vtd_as_by_busptr: 0x560675c521e0, devfn: 0xf8
 lookup result: got vtd_bus
 vtd_bus: 0x5606746aa400
  vtd_bus in s->vtd_as_by_busptr: 0x5606746aa400
  vtd_bus in s->vtd_as_by_busptr: 0x56067457a620
  vtd_bus in s->vtd_as_by_busptr: 0x56067598fef0
    lookup hash_table again, vtd_bus: 0x5606746aa400
------------------------------
YiLiu - vtd_find_add_as()
 bus: 0x5606747f99c0
 s: 0x560675a2e000
 s->vtd_as_by_busptr: 0x560675c521e0, devfn: 0xfa
 lookup result: got vtd_bus
 vtd_bus: 0x5606746aa400
  vtd_bus in s->vtd_as_by_busptr: 0x5606746aa400
  vtd_bus in s->vtd_as_by_busptr: 0x56067457a620
  vtd_bus in s->vtd_as_by_busptr: 0x56067598fef0
    lookup hash_table again, vtd_bus: 0x5606746aa400
------------------------------
YiLiu - vtd_find_add_as()
 bus: 0x5606747f99c0
 s: 0x560675a2e000
 s->vtd_as_by_busptr: 0x560675c521e0, devfn: 0xfb
 lookup result: got vtd_bus
 vtd_bus: 0x5606746aa400
  vtd_bus in s->vtd_as_by_busptr: 0x5606746aa400
  vtd_bus in s->vtd_as_by_busptr: 0x56067457a620
  vtd_bus in s->vtd_as_by_busptr: 0x56067598fef0
    lookup hash_table again, vtd_bus: 0x5606746aa400


4. QEMU version:
commit 48f592118ab42f83a1a7561c4bfd2b72a100f241
Author: Ed Maste <emaste@freebsd.org>
Date:   Tue Oct 4 16:02:49 2016 -0400

    bsd-user: fix FreeBSD build after d148d90e

    Signed-off-by: Ed Maste <emaste@freebsd.org>
    Message-id: 1475611369-74971-1-git-send-email-emaste@freebsd.org
    Signed-off-by: Peter Maydell <peter.maydell@linaro.org>


5. Debug code:
diff --git a/hw/i386/intel_iommu.c b/hw/i386/intel_iommu.c
index 9f4e64a..537d2d4 100644
--- a/hw/i386/intel_iommu.c
+++ b/hw/i386/intel_iommu.c
@@ -1986,7 +1986,7 @@ static void vtd_iommu_notify_flag_changed(MemoryRegion *iommu,
                      "intel-iommu emulation",
                      vtd_as->bus->qbus.name, PCI_SLOT(vtd_as->devfn),
                      PCI_FUNC(vtd_as->devfn));
-        exit(1);
+       // exit(1);//Yi: comment out for test purpose
     }
 }

@@ -2310,15 +2310,33 @@ VTDAddressSpace *vtd_find_add_as(IntelIOMMUState *s, PCIBus *bus, int devfn)
     VTDBus *vtd_bus = g_hash_table_lookup(s->vtd_as_by_busptr, &key);
     VTDAddressSpace *vtd_dev_as;

+    //Yi: add for debug
+    printf("------------------------------\n"
+                    "YiLiu - %s()\n"
+                    " bus: 0x%llx\n"
+                    " s: 0x%llx\n"
+                    " s->vtd_as_by_busptr: 0x%llx, "
+                    "devfn: 0x%x\n",
+                    __FUNCTION__,
+                    (unsigned long long int) bus,
+                    (unsigned long long int) s,
+                    (unsigned long long int) s->vtd_as_by_busptr,
+                    (unsigned int) devfn);
+
     if (!vtd_bus) {
+        printf(" lookup result: no vtd_bus, allocate one\n");
         /* No corresponding free() */
         vtd_bus = g_malloc0(sizeof(VTDBus) + sizeof(VTDAddressSpace *) * \
                             X86_IOMMU_PCI_DEVFN_MAX);
         vtd_bus->bus = bus;
         key = (uintptr_t)bus;
         g_hash_table_insert(s->vtd_as_by_busptr, &key, vtd_bus);
+    } else{
+        printf(" lookup result: got vtd_bus\n");
     }

+    printf(" vtd_bus: 0x%llx\n", (unsigned long long int) vtd_bus);
+
     vtd_dev_as = vtd_bus->dev_as[devfn];

     if (!vtd_dev_as) {
@@ -2338,6 +2356,26 @@ VTDAddressSpace *vtd_find_add_as(IntelIOMMUState *s, PCIBus *bus, int devfn)
         address_space_init(&vtd_dev_as->as,
                            &vtd_dev_as->iommu, "intel_iommu");
     }
+
+    {
+      //Yi: code snippet for debug, dump the vtd_as_by_buspt
+      // r to see if all the allocated vtd_bus are still there
+      GHashTableIter iter;
+      g_hash_table_iter_init(&iter, s->vtd_as_by_busptr);
+      while (g_hash_table_iter_next (&iter, NULL, (void**)&vtd_bus)) {
+         if (pci_bus_num(vtd_bus->bus) == pci_bus_num(bus)) {
+             printf("  vtd_bus in s->vtd_as_by_busptr: 0x%llx\n",
+                                         (unsigned long long int) vtd_bus);
+          }
+      }
+      // look up hash table again see if the result is the same with the
+     //  beginning one.
+      vtd_bus = g_hash_table_lookup(s->vtd_as_by_busptr, &key);
+      printf("    lookup hash_table again"
+                                        ", vtd_bus: 0x%llx\n",
+                                       (unsigned long long int) vtd_bus);
+    }
+
     return vtd_dev_as;
 }

diff --git a/hw/pci/pcie.c b/hw/pci/pcie.c
index 99cfb45..6c83fe9 100644
--- a/hw/pci/pcie.c
+++ b/hw/pci/pcie.c
@@ -683,7 +683,7 @@ void pcie_add_capability(PCIDevice *dev,
            in the linked list */
         next = pcie_find_capability_list(dev, 0, &prev);

-        assert(prev >= PCI_CONFIG_SPACE_SIZE);
+        //assert(prev >= PCI_CONFIG_SPACE_SIZE);
         assert(next == 0);
         pcie_ext_cap_set_next(dev, prev, offset);
     }
diff --git a/hw/vfio/common.c b/hw/vfio/common.c
index 29188a1..3e52d39 100644
--- a/hw/vfio/common.c
+++ b/hw/vfio/common.c
@@ -457,7 +457,7 @@ static void vfio_listener_region_add(MemoryListener *listener,
         QLIST_INSERT_HEAD(&container->giommu_list, giommu, giommu_next);

         memory_region_register_iommu_notifier(giommu->iommu, &giommu->n);
-        memory_region_iommu_replay(giommu->iommu, &giommu->n, false);
+        //memory_region_iommu_replay(giommu->iommu, &giommu->n, false);

         return;
     }

Best Wishes,
Yi Liu

^ permalink raw reply related	[flat|nested] 7+ messages in thread
end of thread, other threads:[~2016-10-12  9:26 UTC | newest]

Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-10-12  5:02 [Qemu-devel] Potential Bug in vIOMMU which may result in memory wasting Liu, Yi L
2016-10-12  7:02 ` no-reply
2016-10-12  7:42   ` Liu, Yi L
2016-10-12  9:26     ` Fam Zheng
  -- strict thread matches above, loose matches on Subject: below --
2016-10-11  9:16 Liu, Yi L
2016-10-11 21:40 ` no-reply
2016-10-12  0:56 ` no-reply

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).