From: Fam Zheng <famz@redhat.com>
To: Kevin Wolf <kwolf@redhat.com>
Cc: qemu-block@nongnu.org, qemu-devel@nongnu.org, armbru@redhat.com,
mreitz@redhat.com
Subject: Re: [Qemu-devel] [PATCH v3] block: Remove "options" indirection from blockdev-add
Date: Wed, 12 Oct 2016 17:41:46 +0800 [thread overview]
Message-ID: <20161012094146.GG28536@lemon> (raw)
In-Reply-To: <1476192424-32557-1-git-send-email-kwolf@redhat.com>
On Tue, 10/11 15:27, Kevin Wolf wrote:
> Now that QAPI supports boxed types, we can have unions at the top level
> of a command, so let's put our real options directly there for
> blockdev-add instead of having a single "options" dict that contains the
> real arguments.
>
> blockdev-add is still experimental and we already made substantial
> changes to the API recently, so we're free to make changes like this
> one, too.
>
> Signed-off-by: Kevin Wolf <kwolf@redhat.com>
> Reviewed-by: Eric Blake <eblake@redhat.com>
> Reviewed-by: Markus Armbruster <armbru@redhat.com>
Nice move!
Reviewed-by: Fam Zheng <famz@redhat.com>
next prev parent reply other threads:[~2016-10-12 9:41 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-11 13:27 [Qemu-devel] [PATCH v3] block: Remove "options" indirection from blockdev-add Kevin Wolf
2016-10-12 9:41 ` Fam Zheng [this message]
2016-10-14 15:55 ` [Qemu-devel] [Qemu-block] " Stefan Hajnoczi
2016-10-15 17:06 ` [Qemu-devel] " Max Reitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161012094146.GG28536@lemon \
--to=famz@redhat.com \
--cc=armbru@redhat.com \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).