From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:47608) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1buG2u-00025d-Kd for qemu-devel@nongnu.org; Wed, 12 Oct 2016 05:41:57 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1buG2t-0004oS-Ph for qemu-devel@nongnu.org; Wed, 12 Oct 2016 05:41:56 -0400 Date: Wed, 12 Oct 2016 17:41:46 +0800 From: Fam Zheng Message-ID: <20161012094146.GG28536@lemon> References: <1476192424-32557-1-git-send-email-kwolf@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1476192424-32557-1-git-send-email-kwolf@redhat.com> Subject: Re: [Qemu-devel] [PATCH v3] block: Remove "options" indirection from blockdev-add List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kevin Wolf Cc: qemu-block@nongnu.org, qemu-devel@nongnu.org, armbru@redhat.com, mreitz@redhat.com On Tue, 10/11 15:27, Kevin Wolf wrote: > Now that QAPI supports boxed types, we can have unions at the top level > of a command, so let's put our real options directly there for > blockdev-add instead of having a single "options" dict that contains the > real arguments. > > blockdev-add is still experimental and we already made substantial > changes to the API recently, so we're free to make changes like this > one, too. > > Signed-off-by: Kevin Wolf > Reviewed-by: Eric Blake > Reviewed-by: Markus Armbruster Nice move! Reviewed-by: Fam Zheng