* [Qemu-devel] [PATCH] net: rocker: set limit to DMA buffer size
@ 2016-10-12 9:10 P J P
2016-10-12 9:52 ` Jiri Pirko
0 siblings, 1 reply; 3+ messages in thread
From: P J P @ 2016-10-12 9:10 UTC (permalink / raw)
To: Qemu Developers; +Cc: Jason Wang, Jiri Pirko, Huawei PSIRT, Prasad J Pandit
From: Prasad J Pandit <pjp@fedoraproject.org>
Rocker network switch emulator has test registers to help debug
DMA operations. While testing host DMA access, a buffer address
is written to register 'TEST_DMA_ADDR' and its size is written to
register 'TEST_DMA_SIZE'. When performing TEST_DMA_CTRL_INVERT
test, if DMA buffer size was greater than 'INT_MAX', it leads to
an invalid buffer access. Limit the DMA buffer size to avoid it.
Reported-by: Huawei PSIRT <psirt@huawei.com>
Signed-off-by: Prasad J Pandit <pjp@fedoraproject.org>
---
hw/net/rocker/rocker.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/net/rocker/rocker.c b/hw/net/rocker/rocker.c
index 30f2ce4..e9d215a 100644
--- a/hw/net/rocker/rocker.c
+++ b/hw/net/rocker/rocker.c
@@ -860,7 +860,7 @@ static void rocker_io_writel(void *opaque, hwaddr addr, uint32_t val)
rocker_msix_irq(r, val);
break;
case ROCKER_TEST_DMA_SIZE:
- r->test_dma_size = val;
+ r->test_dma_size = val & 0xFFFF;
break;
case ROCKER_TEST_DMA_ADDR + 4:
r->test_dma_addr = ((uint64_t)val) << 32 | r->lower32;
--
2.5.5
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [Qemu-devel] [PATCH] net: rocker: set limit to DMA buffer size
2016-10-12 9:10 [Qemu-devel] [PATCH] net: rocker: set limit to DMA buffer size P J P
@ 2016-10-12 9:52 ` Jiri Pirko
2016-10-21 1:33 ` Jason Wang
0 siblings, 1 reply; 3+ messages in thread
From: Jiri Pirko @ 2016-10-12 9:52 UTC (permalink / raw)
To: P J P; +Cc: Qemu Developers, Jason Wang, Huawei PSIRT, Prasad J Pandit
Wed, Oct 12, 2016 at 11:10:55AM CEST, ppandit@redhat.com wrote:
>From: Prasad J Pandit <pjp@fedoraproject.org>
>
>Rocker network switch emulator has test registers to help debug
>DMA operations. While testing host DMA access, a buffer address
>is written to register 'TEST_DMA_ADDR' and its size is written to
>register 'TEST_DMA_SIZE'. When performing TEST_DMA_CTRL_INVERT
>test, if DMA buffer size was greater than 'INT_MAX', it leads to
>an invalid buffer access. Limit the DMA buffer size to avoid it.
>
>Reported-by: Huawei PSIRT <psirt@huawei.com>
>Signed-off-by: Prasad J Pandit <pjp@fedoraproject.org>
Reviewed-by: Jiri Pirko <jiri@mellanox.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [Qemu-devel] [PATCH] net: rocker: set limit to DMA buffer size
2016-10-12 9:52 ` Jiri Pirko
@ 2016-10-21 1:33 ` Jason Wang
0 siblings, 0 replies; 3+ messages in thread
From: Jason Wang @ 2016-10-21 1:33 UTC (permalink / raw)
To: Jiri Pirko, P J P; +Cc: Qemu Developers, Huawei PSIRT, Prasad J Pandit
On 2016年10月12日 17:52, Jiri Pirko wrote:
> Wed, Oct 12, 2016 at 11:10:55AM CEST, ppandit@redhat.com wrote:
>> From: Prasad J Pandit <pjp@fedoraproject.org>
>>
>> Rocker network switch emulator has test registers to help debug
>> DMA operations. While testing host DMA access, a buffer address
>> is written to register 'TEST_DMA_ADDR' and its size is written to
>> register 'TEST_DMA_SIZE'. When performing TEST_DMA_CTRL_INVERT
>> test, if DMA buffer size was greater than 'INT_MAX', it leads to
>> an invalid buffer access. Limit the DMA buffer size to avoid it.
>>
>> Reported-by: Huawei PSIRT <psirt@huawei.com>
>> Signed-off-by: Prasad J Pandit <pjp@fedoraproject.org>
> Reviewed-by: Jiri Pirko <jiri@mellanox.com>
Applied, thanks.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-10-21 1:33 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-10-12 9:10 [Qemu-devel] [PATCH] net: rocker: set limit to DMA buffer size P J P
2016-10-12 9:52 ` Jiri Pirko
2016-10-21 1:33 ` Jason Wang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).