From: David Hildenbrand <dahi@daveh.de>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: Claudio Imbrenda <imbrenda@linux.vnet.ibm.com>, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH v1 2/2] gdbstub: Fix vCont behaviour
Date: Wed, 12 Oct 2016 15:15:25 +0200 [thread overview]
Message-ID: <20161012131525.GA9564@localhost> (raw)
In-Reply-To: <e073af45-24aa-7e6a-2af7-702e4ab9a3c1@redhat.com>
> > + if (def == 0) {
> > + for (cx = 0; scpus && scpus[cx]; cx++) {
> > + cpu_single_step(scpus[cx], sstep_flags);
> > + cpu_resume(scpus[cx]);
> > + }
> > + for (cx = 0; ccpus && ccpus[cx]; cx++) {
> > + cpu_resume(ccpus[cx]);
> > + }
> > + } else if (def == 'c' || def == 'C') {
> > + for (cx = 0; scpus && scpus[cx]; cx++) {
> > + cpu_single_step(scpus[cx], sstep_flags);
> > + }
> > + CPU_FOREACH(cpu) {
> > + cpu_resume(cpu);
> > + }
> > + } else if (def == 's' || def == 'S') {
> > + CPU_FOREACH(cpu) {
> > + cpu_single_step(cpu, sstep_flags);
> > + }
> > + for (cx = 0; ccpus && ccpus[cx]; cx++) {
> > + cpu_single_step(cpu, 0);
This looks suspicious
> > + }
> > + CPU_FOREACH(cpu) {
> > + cpu_resume(cpu);
> > + }
Claudio, did you have a look at how s->c_cpu is used later on? I remember that we
have to take care of some query reply packages.
David
next prev parent reply other threads:[~2016-10-12 13:31 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-10 11:50 [Qemu-devel] [PATCH v1 0/2] Qemu: gdbstub: fix vCont and single-step Claudio Imbrenda
2016-10-10 11:50 ` [Qemu-devel] [PATCH v1 1/2] gdbstub: Fix single-step Claudio Imbrenda
2016-10-10 12:51 ` Christian Borntraeger
2016-10-10 14:36 ` Paolo Bonzini
2016-10-10 15:46 ` [Qemu-devel] [PATCH] kvm-all: don't use stale dbg_data->cpu Alex Bennée
2016-10-10 16:39 ` Paolo Bonzini
2016-10-10 17:18 ` Christian Borntraeger
2016-10-11 11:48 ` Claudio Imbrenda
2016-10-10 11:50 ` [Qemu-devel] [PATCH v1 2/2] gdbstub: Fix vCont behaviour Claudio Imbrenda
2016-10-11 8:18 ` Paolo Bonzini
2016-10-12 13:15 ` David Hildenbrand [this message]
2016-10-12 13:55 ` Claudio Imbrenda
2016-10-12 16:48 ` Paolo Bonzini
2016-10-12 18:38 ` David Hildenbrand
2016-10-13 7:49 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161012131525.GA9564@localhost \
--to=dahi@daveh.de \
--cc=imbrenda@linux.vnet.ibm.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).