From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:52352)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <dahi@daveh.de>) id 1buJd7-0001vK-EI
	for qemu-devel@nongnu.org; Wed, 12 Oct 2016 09:31:34 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <dahi@daveh.de>) id 1buJd1-0001rN-SW
	for qemu-devel@nongnu.org; Wed, 12 Oct 2016 09:31:32 -0400
Received: from wp244.webpack.hosteurope.de ([80.237.133.13]:40185)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <dahi@daveh.de>) id 1buJd1-0001qc-N8
	for qemu-devel@nongnu.org; Wed, 12 Oct 2016 09:31:27 -0400
Date: Wed, 12 Oct 2016 15:15:25 +0200
From: David Hildenbrand <dahi@daveh.de>
Message-ID: <20161012131525.GA9564@localhost>
References: <1476100224-19760-1-git-send-email-imbrenda@linux.vnet.ibm.com>
	<1476100224-19760-3-git-send-email-imbrenda@linux.vnet.ibm.com>
	<e073af45-24aa-7e6a-2af7-702e4ab9a3c1@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <e073af45-24aa-7e6a-2af7-702e4ab9a3c1@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v1 2/2] gdbstub: Fix vCont behaviour
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel/>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: Claudio Imbrenda <imbrenda@linux.vnet.ibm.com>, qemu-devel@nongnu.org

> > +        if (def == 0) {
> > +            for (cx = 0; scpus && scpus[cx]; cx++) {
> > +                cpu_single_step(scpus[cx], sstep_flags);
> > +                cpu_resume(scpus[cx]);
> > +            }
> > +            for (cx = 0; ccpus && ccpus[cx]; cx++) {
> > +                cpu_resume(ccpus[cx]);
> > +            }
> > +        } else if (def == 'c' || def == 'C') {
> > +            for (cx = 0; scpus && scpus[cx]; cx++) {
> > +                cpu_single_step(scpus[cx], sstep_flags);
> > +            }
> > +            CPU_FOREACH(cpu) {
> > +                cpu_resume(cpu);
> > +            }
> > +        } else if (def == 's' || def == 'S') {
> > +            CPU_FOREACH(cpu) {
> > +                cpu_single_step(cpu, sstep_flags);
> > +            }
> > +            for (cx = 0; ccpus && ccpus[cx]; cx++) {
> > +                cpu_single_step(cpu, 0);

This looks suspicious

> > +            }
> > +            CPU_FOREACH(cpu) {
> > +                cpu_resume(cpu);
> > +            }
 
Claudio, did you have a look at how s->c_cpu is used later on? I remember that we
have to take care of some query reply packages.

David