From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:41145) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1buHc9-00070P-2s for qemu-devel@nongnu.org; Wed, 12 Oct 2016 07:22:25 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1buHc4-0005w5-TL for qemu-devel@nongnu.org; Wed, 12 Oct 2016 07:22:24 -0400 Received: from 4.mo179.mail-out.ovh.net ([46.105.36.149]:43533) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1buHc4-0005vc-LZ for qemu-devel@nongnu.org; Wed, 12 Oct 2016 07:22:20 -0400 Received: from player792.ha.ovh.net (b7.ovh.net [213.186.33.57]) by mo179.mail-out.ovh.net (Postfix) with ESMTP id AE799FFC7FD for ; Wed, 12 Oct 2016 13:22:18 +0200 (CEST) Date: Wed, 12 Oct 2016 13:22:08 +0200 From: Greg Kurz Message-ID: <20161012132208.6e22d819@bahia> In-Reply-To: <12493bd0-4812-eaf7-2fa5-ebe675e3ce78@redhat.com> References: <1476192722-22871-1-git-send-email-thuth@redhat.com> <20161011155509.5c422632@bahia> <12493bd0-4812-eaf7-2fa5-ebe675e3ce78@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] tests/boot-sector: Use mkstemp() to create a unique file name List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Thomas Huth Cc: Sascha Silbe , qemu-devel@nongnu.org, qemu-trivial@nongnu.org, Peter Maydell , Victor Kaplansky , qemu-ppc@nongnu.org, Michael Tsirkin On Tue, 11 Oct 2016 16:06:55 +0200 Thomas Huth wrote: > On 11.10.2016 15:55, Greg Kurz wrote: > > On Tue, 11 Oct 2016 15:32:02 +0200 > > Thomas Huth wrote: > > > >> The pxe-test is run for three different targets now (x86_64, i386 > >> and ppc64), and the bios-tables-test is run for two targets (x86_64 > >> and i386). But each of the tests is using an invariant name for the > >> disk image with the boot sector code - so if the tests are running > >> in parallel, there is a race condition that they destroy the disk > >> image of a parallel test program. Let's use mkstemp() to create > >> unique temporary files here instead. > >> > >> Reported-by: Sascha Silbe > >> Signed-off-by: Thomas Huth > >> --- > >> tests/bios-tables-test.c | 2 +- > >> tests/boot-sector.c | 9 +++++++-- > >> tests/boot-sector.h | 4 ++-- > >> tests/pxe-test.c | 2 +- > >> 4 files changed, 11 insertions(+), 6 deletions(-) > >> > >> diff --git a/tests/bios-tables-test.c b/tests/bios-tables-test.c > >> index 6ea2b6d..812f830 100644 > >> --- a/tests/bios-tables-test.c > >> +++ b/tests/bios-tables-test.c > >> @@ -112,7 +112,7 @@ typedef struct { > >> g_assert_cmpstr(ACPI_ASSERT_CMP_str, ==, expected); \ > >> } while (0) > >> > >> -static const char *disk = "tests/acpi-test-disk.raw"; > >> +static char disk[] = "tests/acpi-test-disk-XXXXXX"; > >> static const char *data_dir = "tests/acpi-test-data"; > >> #ifdef CONFIG_IASL > >> static const char *iasl = stringify(CONFIG_IASL); > >> diff --git a/tests/boot-sector.c b/tests/boot-sector.c > >> index e3193c0..e75572f 100644 > >> --- a/tests/boot-sector.c > >> +++ b/tests/boot-sector.c > >> @@ -69,10 +69,15 @@ static uint8_t boot_sector[0x7e000] = { > >> }; > >> > >> /* Create boot disk file. */ > >> -int boot_sector_init(const char *fname) > >> +int boot_sector_init(char *fname) > >> { > >> - FILE *f = fopen(fname, "w"); > >> + FILE *f = NULL; > >> + int fd; > >> > >> + fd = mkstemp(fname); > >> + if (fd != -1) { > >> + f = fdopen(fd, "w"); > >> + } > > > > Unless we really want to control how the temporary file is named (maybe for > > debugging purpose?), I have the impression that using tmpfile(3) would result > > in a simpler patch. > > That unfortunately does not work here - the file name is needed for > starting the QEMU process later (see test_acpi_one() or test_pxe_one() > for details). > Oops you're right *of course*. Then I guess Peter's remark on fwrite()/fclose() should also be addressed, but I see you already sent an update for that :) > Thomas > Cheers. -- Greg